Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Library: remove upload_mimes filter after uploading fonts #54647

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Font Library: remove upload_mimes filter after uploading fonts #54647

merged 1 commit into from
Sep 20, 2023

Conversation

madhusudhand
Copy link
Contributor

What?

This is a followup for #53986, and this review discussion
It adds a fix my removing upload_mimes after the completion of font uploads.

Why?

This restores the global allowed mime types back to their previous values to avoid any unintended issues.

Testing Instructions

Font Uploads should continue to work after this fix.

@madhusudhand madhusudhand mentioned this pull request Sep 20, 2023
Merged
@github-actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/experimental/fonts/font-library/class-wp-font-family.php

@madhusudhand madhusudhand added the [Type] Bug An existing feature does not function as intended label Sep 20, 2023
@madhusudhand madhusudhand mentioned this pull request Sep 20, 2023
Closed
18 tasks
@mikachan mikachan added [Feature] Typography Font and typography-related issues and PRs Needs PHP backport Needs PHP backport to Core labels Sep 20, 2023
mikachan
mikachan approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! Looks like this fixes those failing tests. Also pinging @ramonjd as a second pair of eyes, if you get a chance to review. Thank you!

@mikachan mikachan added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. and removed [Type] Bug An existing feature does not function as intended labels Sep 20, 2023
@mikachan mikachan merged commit 1a3aa05 into trunk Sep 20, 2023
54 checks passed
@mikachan mikachan deleted the font-lib/remove-mime-filter branch September 20, 2023 10:05
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 20, 2023
@SiobhyB SiobhyB mentioned this pull request Sep 25, 2023
Closed
86 tasks
@youknowriad youknowriad added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Needs PHP backport Needs PHP backport to Core labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikachan mikachan mikachan approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@ramonjd ramonjd Awaiting requested review from ramonjd

Assignees
No one assigned
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Feature] Typography Font and typography-related issues and PRs [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
Gutenberg 16.7
Development

Successfully merging this pull request may close these issues.
3 participants
@madhusudhand @mikachan @youknowriad