Use instanceOf over property_exists.

[spacedmonkey]

What?

Trac ticket: https://core.trac.wordpress.org/ticket/59453#ticket

instanceOf is better performance than property_exists

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/block-supports/border.php
❔ lib/block-supports/colors.php
❔ lib/block-supports/typography.php
❔ lib/class-wp-duotone-gutenberg.php

[gziolo]

I’d be also great to verify whether charges from WordPress/wordpress-develop@e77aaf1 got backported, too.

[aaronrobertshaw]

Changes LGTM 👍

One thing that I did notice was the difference in files between this PR and the core patch.

Looking closer at the class-wp-duotone-gutenberg.php file it seems to differ from core.

Was there something that should have been backported from core to Gutenberg?

[aristath]

One thing that I did notice was the difference in files between this PR and the core patch.
Looking closer at the class-wp-duotone-gutenberg.php file it seems to differ from core.
Was there something that should have been backported from core to Gutenberg?

One thing that is different, is that in Gutenberg we use the null coalescing operator in many places. In Core this has not been accepted yet, so where ?? is used in Gutenberg, it was necessary to use isset() checks in Core (same logic and result, just different syntax).
The ?? decision was punted for v6.5, so until then we have 2 options:

• Continue using ?? in Gutenberg since it will be acceptable in 6.5
• Convert ?? to isset() checks in Gutenberg, and then re-convert them to ?? in a few months

[spacedmonkey]

Looking closer at the class-wp-duotone-gutenberg.php file it seems to differ from core.

This needs to be backported. But that is out of scope this this ticket.

[aaronrobertshaw]

Thanks for the extra info @spacedmonkey & @aristath 👍

For the record, what caught my eye was that we had to update the duotone class here in Gutenberg but not in core as the register_duotone_support differed. I understand it is out of scope for this PR, I was only looking to find out what was missed. Which appears to be (WordPress/wordpress-develop@fc53820) if we are looking to make future backports easier.

[getdave]

Looking through this it seems all the changes to files under block-supports/ dir are backported.

Looks like this was done in WordPress/wordpress-develop#5308.

However there is a mismatch between the class-wp-duotone-* files in Gutenberg and Core.

I'm unsure as to why this is and whether anything is outstanding in terms of backports. I'd be grateful for your input here @spacedmonkey @aaronrobertshaw.

[getdave]

This line doesn't seem to appear at all in WP Core

https://github.com/WordPress/wordpress-develop/blob/e83f5a1a602b86dbecbf8ee58d6b8761d53b6197/src/wp-includes/class-wp-duotone.php#L926

[aaronrobertshaw]

At a glance, it appears that the code was refactored a little in core. The check for the block type is handled via the call to block_has_support.

[youknowriad]

So is there a missing backport on this PR. Should we consider it done. It's very unfortunate that the code between core and Gutenberg for block supports have diverged this much.

We should either do:

• Have the exact same code and use a package (like the block-library) sync
• Remove the block supports from Gutenberg (consider that they're now maintained on Core)

It's probably something to do post release though.

[getdave]

So to confirm, no further action on this and it can be marked as backported?

Should we consider it done.

Can I check whether you intended to write We should consider it done?

[getdave]

The code does not match in WP Core

https://github.com/WordPress/wordpress-develop/blob/e83f5a1a602b86dbecbf8ee58d6b8761d53b6197/src/wp-includes/class-wp-duotone.php#L956-L958

[aaronrobertshaw]

As with the previous code difference, I think the core version needed to be backported to Gutenberg. @spacedmonkey might have further context on why it wasn't.

[getdave]

✅ I updated this PR with the Backported to Core label to indicate that the backport has successfully merged into WP Core. I also updated the PHP Sync Tracking Issue for WP 6.5.

There was some uncertainty around the block supports element but that appears to be a wider issue relating to how Gutenberg and Core have become out of sync around these files.