Patterns: Remove pattern category as a variation for post terms block

[glendaviesnz]

What?

Remove pattern category as a variation for post terms block.

Why?

There is no use case for allowing this as a variation and it will likely just cause confusion.
Fixes: #54524

How?

Returns early from the loop that adds variations if the taxonony name === wp_pattern_category

Testing Instructions

• Create a new post or page.
• In the canvas, start typing /cat: Confirm that pattern categories do not show up as a shortcut.
• Insert a categories block.
• In the block sidebar, confirm that "Transform to variation" does not include pattern categories.

Screenshots or screencast

Before:

After:

[github-actions]

Flaky tests detected in 545941f.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6217264063
📝 Reported issues:

• [Flaky Test] should partially select with shift + click (@webkit) #53524 in /test/e2e/specs/editor/various/multi-block-selection.spec.js

[kevin940726]

In the canvas, start typing /cat: Confirm that pattern categories show up as a shortcut.

Should this be NOT show up?

[kevin940726]

Nice one!

• /cat doesn't show the "Pattern categories" block
  

• The transform variations don't include the "Pattern categories" block
  

[glendaviesnz]

In the canvas, start typing /cat: Confirm that pattern categories show up as a shortcut.

Should this be NOT show up?

yeh, thanks, have updated the description for future reference.

[mikachan]

👋 I'm running through some PRs that have the Needs PHP backport label. As this change is in the Block Library package, does this still need a PHP backport to Core, or will it be included in the package updates?

[hellofromtonya]

👋 I'm running through some PRs that have the Needs PHP backport label. As this change is in the Block Library package, does this still need a PHP backport to Core, or will it be included in the package updates?

👋 @mikachan, the PHP changes seem to be in packages. You're right, these changes will come to Core as part of the package update.

[mikachan]

Thanks @hellofromtonya, I've removed the backport label!