Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Pattern categories" taxonomy is available as a Categories block variation #54524

Closed
carolinan opened this issue Sep 17, 2023 · 2 comments · Fixed by #54532
Closed

"Pattern categories" taxonomy is available as a Categories block variation #54524

carolinan opened this issue Sep 17, 2023 · 2 comments · Fixed by #54532
Assignees
Labels
[Block] Categories Affects the Categories Block [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@carolinan
Copy link
Contributor

Description

Pattern categories are available as a Categories block variation.
I wonder if this is on purpose, what would the use case be for printing a pattern category in the editor and front?

Step-by-step reproduction instructions

Create a new post or page.
In the canvas, start typing /cat: Confirm that pattern categories show up as a shortcut.

Insert a categories block.
In the block sidebar, confirm that "Transform to variation" includes pattern categories.

Screenshots, screen recording, code snippet

pattern categories in inserter Pattern categories in the transforms dropdown

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@carolinan carolinan added [Block] Pattern Affects the Patterns Block [Block] Categories Affects the Categories Block [Type] Question Questions about the design or development of the editor. labels Sep 17, 2023
@carolinan
Copy link
Contributor Author

Also when there are no pattern categories the default text is "No tags".

@glendaviesnz
Copy link
Contributor

This is just accidental as the post term block was just grabbing every built in taxonomy as a variation. There is a PR here to fix this.

@glendaviesnz glendaviesnz added [Type] Bug An existing feature does not function as intended [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced and removed [Type] Question Questions about the design or development of the editor. [Block] Pattern Affects the Patterns Block labels Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Categories Affects the Categories Block [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants