Style engine: update docs for css_var #5255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The css_var property used to be this way, e.g., '--wp--preset--color--$slug' => 'color' , but then we swapped it around.
86 tasks
|
Committed in r56630 |
audrasjb
requested changes
Sep 20, 2023
| * `array( "$property" => "$value", ... )`. | ||
| * Style definitions that contain the instructions to parse/output valid Gutenberg styles from a block's attributes. | ||
| * | ||
| * For every style definition, the follow properties are valid: |
There was a problem hiding this comment.
I'm not a native English speaker but "the following properties" seems to be the correct (or at least more consistent) form here.
There was a problem hiding this comment.
You're right. Thanks for picking up on that. I blindly copied and pasted.
There was a problem hiding this comment.
Looks like it's been committed. I can create a new PR since it's an embarrassing spelling error (for me).
Changeset: #5256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doc comments for css_var were topsy turvy.
The css_var property used to be this way, e.g., '--wp--preset--color--$slug' => 'color' , but then we swapped it around.
Syncing Gutenberg commit from WordPress/gutenberg#53710
Trac ticket: https://core.trac.wordpress.org/ticket/59401
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.