Sync: Don't enqueue edit site stylesheet in iframe #5309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 tasks
| @@ -299,7 +299,7 @@ function get_legacy_widget_block_editor_settings() { | |||
| * } | |||
| */ | |||
| function _wp_get_iframed_editor_assets() { | |||
| global $wp_styles, $wp_scripts, $pagenow; | |||
| global $wp_styles, $wp_scripts; | |||
There was a problem hiding this comment.
@Mamaduka Remove the global annotation from document.
* @global string $pagenow The filename of the current screen.
There was a problem hiding this comment.
Thanks @mukeshpanchal27. I'll take care of this when committing.
hellofromtonya
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Compared the function and changes to what's in Gutenberg. This PR removes the part that is no longer needed.
When committing, I'll remove the @global reference in the DocBlock, as noted by @mukeshpanchal27.
This patch is ready for commit.
|
Committed via https://core.trac.wordpress.org/changeset/56736. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is probably better to merge after packages are synced, because without CSS changes from the PR the site editor produced as console warning.
Gutenberg PR: WordPress/gutenberg#54254
Trac ticket: https://core.trac.wordpress.org/ticket/59456
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.