Design Tools: Add block instance elements color support for buttons and headings #5164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 tasks
|
Thanks for the review @tellthemachines 👍
I was in two minds about this, on one hand it would be good to confirm that elements styles are generated appropriately, on the other hand it's really just testing the style engine. Ultimately, my reasoning in omitting it was as you suggested, it doesn't really return anything of note. |
|
Committed in r56604. |
aaronrobertshaw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport PR for WordPress 6.4 that includes the following PHP Gutenberg changes:
It also adds a couple of unit tests to cover the application of the
wp-elements-*classname for buttons and headings.Trac ticket: https://core.trac.wordpress.org/ticket/59309
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.