Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elements: Add unit tests for class and style generation #55113

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Elements: Add unit tests for class and style generation #55113

merged 3 commits into from
Oct 6, 2023

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds unit tests for the elements block support.

Why?

Prevent regressions and increase confidence while refactoring to improve performance.

How?

Add PHPUnit tests.

Testing Instructions

npm run test:unit:php:base -- --filter WP_Block_Supports_Elements_Test

Screenshots or screencast

Screenshot 2023-10-06 at 2 30 04 pm

@aaronrobertshaw aaronrobertshaw added [Type] Code Quality Issues or PRs that relate to code quality [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Oct 6, 2023
@aaronrobertshaw aaronrobertshaw self-assigned this Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ phpunit/block-supports/elements-test.php

andrewserong
andrewserong approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, thanks for adding the test coverage here @aaronrobertshaw!

Found one tiny copy/paste error in a test message, but otherwise LGTM! ✨

phpunit/block-supports/elements-test.php Outdated Show resolved Hide resolved
@aaronrobertshaw @andrewserong
Update phpunit/block-supports/elements-test.php
d790e3d 
Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
@ramonjd
Copy link
Member

ramonjd commented Oct 6, 2023

Nice one! Thanks for writing these. LGTM

@aaronrobertshaw aaronrobertshaw enabled auto-merge (squash) October 6, 2023 04:48
@aaronrobertshaw aaronrobertshaw merged commit ed29c89 into trunk Oct 6, 2023
49 checks passed
@aaronrobertshaw aaronrobertshaw deleted the add/elements-block-support-unit-tests branch October 6, 2023 05:35
@github-actions github-actions bot added this to the Gutenberg 16.9 milestone Oct 6, 2023
This was referenced Oct 6, 2023
Closed
Closed
@getdave getdave mentioned this pull request Jan 18, 2024
Closed
@aaronrobertshaw aaronrobertshaw added the Backported to WP Core Pull request that has been successfully merged into WP Core label Jan 25, 2024
@aaronrobertshaw
Copy link
Contributor Author

Backported to core via WordPress/wordpress-develop#5418
Commited in https://core.trac.wordpress.org/changeset/56806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewserong andrewserong andrewserong approved these changes

@ramonjd ramonjd Awaiting requested review from ramonjd

Assignees

@aaronrobertshaw aaronrobertshaw

Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 16.9
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronrobertshaw @ramonjd @andrewserong