Experimental: Fix TinyMCE removal for heartbeat requests #52935

tyxla · 2023-07-25T12:18:35Z

What?

This PR fixes warnings that are thrown for heartbeat requests when the TinyMCE removal experiment is turned on.

The warnings are easy to see in your browser console if you have the Query Monitor plugin installed.

Why?

We're just fixing some warnings:

Found while working on #52811.

How?

We're moving the $current_post declaration outside the condition that declares it and moving the condition above. That way, the code that uses $current_post will actually be reached only when necessary.

Testing Instructions

Install the Query Monitor plugin.
Open the post editor for an existing post.
Wait for a minute to witness a heartbeat XHR request to run.
Verify there are no longer warnings.
Try the same as above but for a custom post type.
Verify test instructions in Try: Aggressive TinyMCE deprecation #50387 still work well.

Testing Instructions for Keyboard

None.

Screenshots or screencast

None.

github-actions · 2023-07-25T12:20:37Z

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/experimental/disable-tinymce.php

github-actions · 2023-07-25T13:29:51Z

Flaky tests detected in 2931e45.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5657072477
📝 Reported issues:

[Flaky Test] zoom animation #52381 in /test/e2e/specs/editor/blocks/image.spec.js

skorasaurus · 2023-07-25T17:03:38Z

This PR removes PHP warnings that had appeared in the background (that I mention at #52936 (comment)) but...

The classic block appears in the block inserter and I can insert a classic block, add some text content and save a new post, even with the post type of post.

tyxla · 2023-07-26T07:48:55Z

The classic block appears in the block inserter and I can insert a classic block, add some text content and save a new post, even with the post type of post.

Odd, I'm unable to reproduce. Is there a chance you checked this PR out and didn't trigger a fresh Gutenberg build? I wonder if we can get a second opinion since I really want to land this and resolve the PHP warnings that are appearing and blocking testing of the rest of the PRs that address #52811.

Mamaduka · 2023-07-26T07:54:12Z

I should've checked this PR before filing my own 😅 Going to test it now.

lib/experimental/disable-tinymce.php

Mamaduka · 2023-07-26T07:55:58Z

lib/experimental/disable-tinymce.php

-		$content = $current_post->post_content;
+	// Bail if for some reason the post isn't found.
+	$current_post = get_post( intval( $_GET['post'] ) );
+	if ( ! $current_post || is_wp_error( $current_post ) ) {


We can remove the is_wp_error check here. See https://developer.wordpress.org/reference/functions/get_post/#return

I was almost sure that WP_Post could return a WP_Error, but I must have misremembered! Anyway, you're right, fixed in 6bb68ee

jsnajdr

lgtm 👍

Post IDs are supposed to be non-negative integers. Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>

Mamaduka

Resolves the issue with PHP warnings.

I'm also unable to reproduce the inserter behavior that @skorasaurus reported. The Classic block isn't available in the inserter for me.

tyxla · 2023-07-26T08:02:24Z

Thank you both 🙌 Will ship ASAP to resolve the warnings.

github-actions · 2023-09-05T17:26:41Z

Warning: Type of PR label error

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

Type-related labels to choose from: [Type] Accessibility (a11y), [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
Labels found: [Type] Enhancement, [Package] Block library, [Block] Classic, [Type] Experimental.

Read more about Type labels in Gutenberg.

tyxla added [Type] Enhancement A suggestion for improvement. [Package] Block library /packages/block-library [Block] Classic Affects the Classic Editor Block [Type] Experimental Experimental feature or API. labels Jul 25, 2023

tyxla requested review from mcsf, Mamaduka, youknowriad, getdave, mtias, jsnajdr, dmsnell and flootr July 25, 2023 12:18

tyxla self-assigned this Jul 25, 2023

tyxla requested a review from spacedmonkey as a code owner July 25, 2023 12:18

Experimental: Fix TinyMCE removal for heartbeat requests

2931e45

tyxla force-pushed the fix/tinymce-heartbeat-requests branch from c3adc45 to 2931e45 Compare July 25, 2023 12:56

tyxla mentioned this pull request Jul 25, 2023

'Freeform' block is not supported error appears in between a custom post type's template blocks #52811

Closed

skorasaurus mentioned this pull request Jul 25, 2023

Block Library: Set freeform handler only if Classic block exists #52936

Merged

Mamaduka reviewed Jul 26, 2023

View reviewed changes

lib/experimental/disable-tinymce.php Outdated Show resolved Hide resolved

Mamaduka reviewed Jul 26, 2023

View reviewed changes

jsnajdr approved these changes Jul 26, 2023

View reviewed changes

Mamaduka mentioned this pull request Jul 26, 2023

Fix PHP warnings coming from Classic block compat experiment #52967

Closed

intval => absint

b10ca33

Post IDs are supposed to be non-negative integers. Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>

Mamaduka approved these changes Jul 26, 2023

View reviewed changes

get_post() cannot return a WP_Error

6bb68ee

tyxla enabled auto-merge (squash) July 26, 2023 08:02

tyxla merged commit a78a632 into trunk Jul 26, 2023

tyxla deleted the fix/tinymce-heartbeat-requests branch July 26, 2023 08:31

github-actions bot added this to the Gutenberg 16.4 milestone Jul 26, 2023

SiobhyB mentioned this pull request Sep 5, 2023

Plugin: Synchronize PHP changes for WordPress 6.4 release #54177

Closed

86 tasks

SiobhyB added the Needs PHP backport Needs PHP backport to Core label Sep 5, 2023

mikachan removed the Needs PHP backport Needs PHP backport to Core label Sep 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Experimental: Fix TinyMCE removal for heartbeat requests #52935

Experimental: Fix TinyMCE removal for heartbeat requests #52935

tyxla commented Jul 25, 2023 •

edited

Loading

github-actions bot commented Jul 25, 2023

github-actions bot commented Jul 25, 2023 •

edited

Loading

skorasaurus commented Jul 25, 2023

tyxla commented Jul 26, 2023

Mamaduka commented Jul 26, 2023

Mamaduka Jul 26, 2023

tyxla Jul 26, 2023

jsnajdr left a comment

Mamaduka left a comment

tyxla commented Jul 26, 2023

github-actions bot commented Sep 5, 2023 •

edited

Loading

Experimental: Fix TinyMCE removal for heartbeat requests #52935

Experimental: Fix TinyMCE removal for heartbeat requests #52935

Conversation

tyxla commented Jul 25, 2023 • edited Loading

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

github-actions bot commented Jul 25, 2023

github-actions bot commented Jul 25, 2023 • edited Loading

skorasaurus commented Jul 25, 2023

tyxla commented Jul 26, 2023

Mamaduka commented Jul 26, 2023

Mamaduka Jul 26, 2023

Choose a reason for hiding this comment

tyxla Jul 26, 2023

Choose a reason for hiding this comment

jsnajdr left a comment

Choose a reason for hiding this comment

Mamaduka left a comment

Choose a reason for hiding this comment

tyxla commented Jul 26, 2023

github-actions bot commented Sep 5, 2023 • edited Loading

tyxla commented Jul 25, 2023 •

edited

Loading

github-actions bot commented Jul 25, 2023 •

edited

Loading

github-actions bot commented Sep 5, 2023 •

edited

Loading