-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental: Backend handle freeform blocks with TinyMCE removal #52938
Conversation
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/disable-tinymce.php |
ec77b35
to
3882776
Compare
Flaky tests detected in bf7a161. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5666635087
|
3882776
to
bf7a161
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected ✅
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
What?
Handle
freeform
blocks properly as classic blocks and load the Classic block and TinyMCE properly.Part of the fix for #52811.
Why?
There are pre-existing posts that specifically have
freeform
blocks and we need to handle them properly when the TinyMCE experiment is enabled.How?
In addition to treating a raw block with content and no name as a Classic block, treat
core/freeform
blocks as such.Testing Instructions
Testing Instructions for Keyboard
None
Screenshots or screencast
None