Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental: Backend handle freeform blocks with TinyMCE removal #52938

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Jul 25, 2023

What?

Handle freeform blocks properly as classic blocks and load the Classic block and TinyMCE properly.

Part of the fix for #52811.

Why?

There are pre-existing posts that specifically have freeform blocks and we need to handle them properly when the TinyMCE experiment is enabled.

How?

In addition to treating a raw block with content and no name as a Classic block, treat core/freeform blocks as such.

Testing Instructions

<!-- wp:freeform -->
<p>test</p>
<!-- /wp:freeform -->
  • Save the post.
  • Refresh the page.
  • Verify you can see the Classic block and it works correctly.

Testing Instructions for Keyboard

None

Screenshots or screencast

None

@tyxla tyxla added [Type] Enhancement A suggestion for improvement. [Package] Block library /packages/block-library [Block] Classic Affects the Classic Editor Block [Type] Experimental Experimental feature or API. labels Jul 25, 2023
@tyxla tyxla self-assigned this Jul 25, 2023
@tyxla tyxla requested a review from spacedmonkey as a code owner July 25, 2023 12:50
@github-actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/experimental/disable-tinymce.php

@github-actions
Copy link

github-actions bot commented Jul 25, 2023

Flaky tests detected in bf7a161.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5666635087
📝 Reported issues:

@tyxla tyxla force-pushed the fix/tinymce-removal-handle-freeform branch from 3882776 to bf7a161 Compare July 26, 2023 08:46
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected ✅

@tyxla tyxla merged commit d17cd9c into trunk Jul 26, 2023
49 checks passed
@tyxla tyxla deleted the fix/tinymce-removal-handle-freeform branch July 26, 2023 10:01
@github-actions github-actions bot added this to the Gutenberg 16.4 milestone Jul 26, 2023
@SiobhyB SiobhyB added the Needs PHP backport Needs PHP backport to Core label Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Warning: Type of PR label error

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Accessibility (a11y), [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: [Type] Enhancement, [Package] Block library, [Block] Classic, [Type] Experimental.

Read more about Type labels in Gutenberg.

@mikachan mikachan removed the Needs PHP backport Needs PHP backport to Core label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Classic Affects the Classic Editor Block [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement. [Type] Experimental Experimental feature or API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants