Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: setting wp_font_family custom post type as _builtin and not plublic #54559

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

matiasbenedetto
Copy link
Contributor

What?

fixes #54526

@matiasbenedetto matiasbenedetto added [Type] Bug An existing feature does not function as intended [Feature] Typography Font and typography-related issues and PRs labels Sep 18, 2023
@matiasbenedetto matiasbenedetto added the Needs PHP backport Needs PHP backport to Core label Sep 18, 2023
@github-actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/experimental/fonts/font-library/font-library.php

@github-actions
Copy link

Flaky tests detected in 9dcb16b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6223531976
📝 Reported issues:

Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
Copy link
Contributor

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and verified that Font Library does not appear in the Query Loop Post Types dropdown.

Also not sure why the e2e 3 tests keep failing but it seems unrelated.

@matiasbenedetto matiasbenedetto merged commit 5969668 into trunk Sep 18, 2023
49 checks passed
@matiasbenedetto matiasbenedetto deleted the fix/54526 branch September 18, 2023 17:55
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 18, 2023
@youknowriad youknowriad added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Needs PHP backport Needs PHP backport to Core labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Feature] Typography Font and typography-related issues and PRs [Type] Bug An existing feature does not function as intended
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Query Loop: "Font Library" appears in the post type dropdown
4 participants