Update locked pattern tooltips #52497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +262 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in de4bedf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5532665362
|
|
A bit verbose, but I'm not sure of an alternative. Perhaps "Uneditable patterns"? |
|
Ideally there would be some logic to display "$source patterns cannot be edited". But I wasn't sure how to handle that, or if it was worth the expense. I think the important thing is to not ship the inaccurate description. |
|
I pushed a some alternatives: 
What do you think @richtabor ? |
|
This change makes sense. LGTM 
Do you think it's also worth updating the following string for consistency??
|
I don't have a strong feeling either way on that one. The original copy suggests any entity that uses the pattern will be updated, which is kind of true as well. It's very long though, if there's a way to condense that tooltip that would get my vote. Probably one to look at separately though. |
apeatling
approved these changes
Jul 17, 2023
westonruter
added a commit
that referenced
this pull request
Jul 18, 2023
* trunk: (36 commits) Use `_get_block_template_file` function and set $area variable. (#52708) Change Delete page menu item to Move to trash. (#52641) Search block: Enqueue view script through block.json (#52552) Patterns: fix bug with Create Patterns menu not showing in site editor page editing (#52671) Github workflow: add a PHP backport changes action (#52096) Add layout API documentation. (#52673) Show uncategorized patterns on the Editor > Patterns page (#52633) Patterns: Remove `reusable` text from menu once rename hint has been dismissed (#52664) Update locked pattern tooltips (#52497) Rich Text/Footnotes: fix getRichTextValues for useInnerBlocksProps.save (#52682) Use posts instead of template parts for navigation color tests (#52654) Site Editor: Don't allow creating template part on the Patterns page for non-block themes (#52656) Site Editor: Fix incorrect 'useSelect' usage (#52683) Update issue gardening automation with new label (#52173) i18n: Make the tab labels of `ColorGradientSettingsDropdown` component translatable (#52669) Post Content link color should not be applied to placeholder component links (#52367) [Mobile] Update toolbar icons and colors (#52336) Avoid copying global style presets via the styles compatibility hook (#52640) Show warning on removal of Post Template block in the site editor. (#52666) Backport tools: sort PRs to be cherry picked by merged/closed date (#52667) ...
92 tasks
mburridge
added
[Type] Enhancement
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update locked pattern tooltips to include plugins.
Why?
Currently, hovering the lock icon on patterns added by a plugin reveals a tooltip stating:
This PR updates that string to include plugins:
How?
Update text string.
Testing Instructions.
It might be nice to add some logic to make the tooltip contextual, but I'm not sure it's worth the effort. This feels like an easy change to cover the issue of mis-labelled plugin patterns.