-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore sidebar in focus mode on Pattern click through in Browse Mode Library
#51897
Conversation
Size Change: +4 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what it's worth, I much prefer this flow.
My understanding is this wasn't the flow when the design video for the library was shared. That design was what we worked towards but it appears that before the library landed the navigation editing work changed the flow to always go via view mode. I don't have any strong feelings towards this. Each pattern in the library went to edit mode simply due to consistency with how it originally worked and the design. The navigation editing feature in the sidebar does present a valid reason to switch the patterns to go via view mode. |
@aaronrobertshaw Yeh it seems like there was some inconsistency in the designs around Library and Navigation sections. All good 👍
I agree. If later we find it's mostly ending up as a blank sidebar (and that's deemed a problem) we can conditionalise this based on whether there is a Navigation in the pattern. |
I'm going to wait on someone from @WordPress/gutenberg-design to approve / merge this one as @jameskoster has specifically tagged it. |
There are some minor updates in the pipeline on that front: #51954 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Let's give this a go then.
I just cherry-picked this PR to the release/16.1 branch to get it included in the next release: 8256ef9 |
I just cherry-picked this PR to the add/pre-beta1-bugfixes branch to get it included in the next release: 1bea96c |
* Restore sidebar in focus mode on Pattern click through in Browse Mode Library (#51897) Brings back #51492 * [Command center]: Add preferences and keyboard shortcuts commands (#51862) * [Command center]: Add preferences and keyboard shortcuts commands * update labels * [Site Editor]: Fix `library` command path (#51837) * Updating social link attributes (#51997) * Try: Update template titles (#51428) * Update template titles * Fix typo Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com> * Revert Index rename * "front page" -> "homepage" * Update 404 Page make more sense given the template appears in the Pages panel too. * Front Page * home title + description * Revert Home name change, and move compat files * separate code for wp versions * update tests --------- Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com> Co-authored-by: ntsekouras <ntsekouras@outlook.com> * Update text color (#51965) * Modal: Add small top padding to the content so that avoid cutting off the visible outline when hovering items (#51829) * Site Editor: Fix focus cutoff in add template modal * Add padding-top to the modal content * Remove unnecessary padding-top * Remove unnecessary padding-top * Update changelog * Revert top padding from block patterns list * Revert top padding from block patterns list * Remove unnecessary changes * Remove unnecessary changes * Add CSS inline comment * Change padding metrics * Rest API: rename navigation fallback classes from WP_ to Gutenberg_ (#51959) * The `WP_REST_Navigation_Fallback_Controller` class has been committed to core and therefore results in a naming conflict and unit test failures. Ideally `WP_REST_Navigation_Fallback_Controller` should have been named `WP_REST_Navigation_Fallback_Controller_Gutenberg` and extended `WP_REST_Navigation_Fallback_Controller`. But we can conditionally load the file instead. * Renamed WP_Classic_To_Block_Menu_Converter to Gutenberg_Classic_To_Block_Menu_Converter Load WP_REST_Navigation_Fallback_Controller dependencies in load.php * Renamed all 6.3 classes to have the Gutenberg_ prefix. This should avoid compat errors and hopefully some confusion later. * Also rename test files for completeness * Updated deprecation notices to refer to Gutenberg classes * Fix phpunit failures (#51950) * Fix phpunit failures * Add comment * Update comment with actual reason this fix works --------- Co-authored-by: Dave Smith <getdavemail@gmail.com> Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: James Koster <james@jameskoster.co.uk> Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com> Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: Robert Anderson <robert@noisysocks.com>
… Library (WordPress#51897) Brings back WordPress#51492
What?
Updates the link when clicking through from a Browse Mode Library item into focus mode to default to
view
mode rather thanedit
.Fixes #51839
Why?
As detailed in the associated Issue, not showing the sidebar means #51492 is effectively hidden from the user.
This PR restores it to be a feature users will actually encounter.
How?
Sets route to
view
rather thanedit
.Testing Instructions
Header
template part / pattern has a Navigation block with a menu in it.LIbrary
in Browse mode and click through to yourHeader
pattern.canvas=view
in it.Testing Instructions for Keyboard
Screenshots or screencast