Add Navigation Menus to Template Parts screen sidebar in Browse Mode #51492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Block] Navigation
getdave
commented
Jun 14, 2023
packages/edit-site/src/components/sidebar-navigation-screen-navigation-menu/index.js
Outdated
Show resolved
Hide resolved
getdave
requested review from
scruffian,
jameskoster,
SaxonF,
jasmussen,
richtabor and
MaggieCabrera
getdave
changed the title
getdave
changed the title
getdave
force-pushed
the
add/nav-menus-to-template-part-in-browse-mode
branch
from
f7a9f24
to
827eeea
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Size Change: +921 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Trying to test this throws: |
|
Flaky tests detected in 827eeea. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5269504492
|
getdave
force-pushed
the
add/nav-menus-to-template-part-in-browse-mode
branch
from
827eeea
to
77b8389
Compare
I rebased the branch and I can build it 🤷 Did you check your Node version? |
13 tasks
jasmussen
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
This is a really solid experience, and depending on where individual focus mode editing goes in the future, it might even be able to become the primary interface for editing navigation:
For now it seems good to land both and then pull back as we learn more. Thanks!
I'm not sure if this is really a bug, I think that's the intended behaviour, although I do agree we should change it :) |
scruffian
reviewed
Jun 15, 2023
packages/edit-site/src/components/sidebar-navigation-screen-navigation-menu/index.js
Outdated
Show resolved
Hide resolved
scruffian
reviewed
Jun 15, 2023
packages/edit-site/src/components/sidebar-navigation-screen-navigation-menu/index.js
Show resolved
Hide resolved
scruffian
reviewed
Jun 15, 2023
packages/edit-site/src/components/sidebar-navigation-screen-template-part/index.js
Outdated
Show resolved
Hide resolved
scruffian
reviewed
Jun 15, 2023
...site/src/components/sidebar-navigation-screen-template-part/template-part-navigation-menu.js
Outdated
Show resolved
Hide resolved
scruffian
reviewed
Jun 15, 2023
...ite/src/components/sidebar-navigation-screen-template-part/template-part-navigation-menus.js
Outdated
Show resolved
Hide resolved
Yes, actually I agree. It's not a problem of this PR. |
scruffian
reviewed
Jun 15, 2023
...ite/src/components/sidebar-navigation-screen-template-part/template-part-navigation-menus.js
Outdated
Show resolved
Hide resolved
…mplate-part/template-part-navigation-menus.js
…mplate-part/template-part-navigation-menu.js
scruffian
reviewed
Jun 15, 2023
| @@ -0,0 +1,3 @@ | |||
| .edit-site-sidebar-navigation-screen-template-part-navigation-menu__title.components-heading { | |||
| margin-bottom: $grid-unit-10; | |||
There was a problem hiding this comment.
@jasmussen it seems strange to have a different spacing for the heading component just on this one screen, do you think we should make this change to all heading components in browse mode? Maybe in a different PR?
There was a problem hiding this comment.
Yes, @jameskoster is still hashing out the metrics of the heading and subheading components, but they should all be the same. Good catch.
There was a problem hiding this comment.
Ok, I'll open a followup for this :)
|
I have a report from @draganescu that this doesn't work with Archeo theme has been using. Needs investigating. |
This was referenced Jun 16, 2023
tellthemachines
added a commit
that referenced
this pull request
Jun 28, 2023
* Restore sidebar in focus mode on Pattern click through in Browse Mode Library (#51897) Brings back #51492 * [Command center]: Add preferences and keyboard shortcuts commands (#51862) * [Command center]: Add preferences and keyboard shortcuts commands * update labels * [Site Editor]: Fix `library` command path (#51837) * Updating social link attributes (#51997) * Try: Update template titles (#51428) * Update template titles * Fix typo Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com> * Revert Index rename * "front page" -> "homepage" * Update 404 Page make more sense given the template appears in the Pages panel too. * Front Page * home title + description * Revert Home name change, and move compat files * separate code for wp versions * update tests --------- Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com> Co-authored-by: ntsekouras <ntsekouras@outlook.com> * Update text color (#51965) * Modal: Add small top padding to the content so that avoid cutting off the visible outline when hovering items (#51829) * Site Editor: Fix focus cutoff in add template modal * Add padding-top to the modal content * Remove unnecessary padding-top * Remove unnecessary padding-top * Update changelog * Revert top padding from block patterns list * Revert top padding from block patterns list * Remove unnecessary changes * Remove unnecessary changes * Add CSS inline comment * Change padding metrics * Rest API: rename navigation fallback classes from WP_ to Gutenberg_ (#51959) * The `WP_REST_Navigation_Fallback_Controller` class has been committed to core and therefore results in a naming conflict and unit test failures. Ideally `WP_REST_Navigation_Fallback_Controller` should have been named `WP_REST_Navigation_Fallback_Controller_Gutenberg` and extended `WP_REST_Navigation_Fallback_Controller`. But we can conditionally load the file instead. * Renamed WP_Classic_To_Block_Menu_Converter to Gutenberg_Classic_To_Block_Menu_Converter Load WP_REST_Navigation_Fallback_Controller dependencies in load.php * Renamed all 6.3 classes to have the Gutenberg_ prefix. This should avoid compat errors and hopefully some confusion later. * Also rename test files for completeness * Updated deprecation notices to refer to Gutenberg classes * Fix phpunit failures (#51950) * Fix phpunit failures * Add comment * Update comment with actual reason this fix works --------- Co-authored-by: Dave Smith <getdavemail@gmail.com> Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: James Koster <james@jameskoster.co.uk> Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com> Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: Robert Anderson <robert@noisysocks.com>
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…ordPress#51492) * Proof of concept * Rename function Addresses WordPress#51492 (comment) * Space docblocks * Update packages/edit-site/src/components/sidebar-navigation-screen-template-part/template-part-navigation-menus.js * Update packages/edit-site/src/components/sidebar-navigation-screen-template-part/template-part-navigation-menu.js * remove unneeded comment * Output a string when a navigation has no title --------- Co-authored-by: Ben Dwyer <ben@scruffian.com>
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
… Library (WordPress#51897) Brings back WordPress#51492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Displays any Navigation Menus in the Template Part in the sidebar of the single Templates Part screen in the Browse Mode sidebar.
Closes #50704
Why?
Part of requirements from #50579.
When browsing a template part that contains Navigation block(s) such as the common
Headertemplate part, you want to be able to view or even edit any menus displayed there.How?
If there is a single menu then it is displayed directly inline as an editable tree.
If there are multiple menus then they are displayed as a list and you can click through to the Navigation block focus mode (not yet merged) to edit the menu.
Todos
Fix bug where clicking through to a single menu and then going back causes you to go to theOutside scope of this PR.Navigationsection rather than back to the Template Part.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2023-06-14.at.16-41-51.mp4