Site Editor: Fix the template parts link on the list page #52891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Site Editor
|
I also noticed that when a URL query contains Behold, the "black screen of death" 😄 CleanShot.2023-07-24.at.17.49.28.mp4 |
|
Size Change: -5 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Jul 24, 2023
|
Flaky tests detected in 9e989db. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5645727825
|
I don't believe this was a regression but a desired outcome according to #51897. It's so the sidebar navigation editing feature isn't hidden by default (further history) Unless that reasoning has changed, I think this might need reverting. cc/ @getdave, @scruffian, @carolinan, @jameskoster |
|
While I would personally like the sidebar to show initially and when going back one step from editing, |
tellthemachines
pushed a commit
that referenced
this pull request
Jul 25, 2023
|
I just cherry-picked this PR to the update/further-bugfixes-rc2 branch to get it included in the next release: 453af8b |
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
|
Thanks for the context, @aaronrobertshaw! Specifying the |
That's only for hybrid themes, correct? Is there no way to only switch the canvas default to edit only if it's a hybrid theme? |
|
No, it happens for block themes too. I think there's a bug in URL sync logic or editor initialization logic, but those are delicate parts of the editor, and I would like to avoid shipping changes to them in WP 6.3 RCs. I've created an alternative PR that fixes the reloading issue but keeps the initial canvas mode as the view -#52916. |
ramonjd
added a commit
that referenced
this pull request
Jul 25, 2023
* Fix image block v6 deprecation (#52822) * Remove incorrect comment * Add missing attribtes and supports * Add integration tests for the deprecation * Fix incorrect import * Fix fixtures * Image: Use the correct method for caption class in recent deprecation (#52853) * Distraction Free: Fix notices in site editor (#52867) * Distraction Free: Add missing command in site editor (#52868) * Site Editor: Fix the template parts link on the list page (#52891) * Return focus more from focus return hook (#52710) * Disambiguate "Import" button string. (#52907) * Disambiguate "Import" button string. * Add _x to import --------- Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> * My patterns page: Increase color contrast for the toggle group (#52678) * Update style.scss * Update style.scss * Check if object exists before accessing its properties. (#52870) * Check if object exists before accessing its properties. * Name anonymous functions * Update names * Sidebar: Restore Back buton 'go to parent' functionality (#52910) * Global styles revisions: display text if no revisions are found (#52865) * If somehow a user lands on the revisions panel when there are no revisions, show some helpful text rather than a loading spinner. Also, add an E2E test! * Updated unit tests to reflect resolver logic changes * Use existing string * Only open edit view when testing the revisions panel itself * ResizableFrame: Account for window resizing (#52697) * ResizableFrame: Account for window resizing * Don't memoize --------- Co-authored-by: Robert Anderson <robert@noisysocks.com> * Distraction Free: Fix conflict with showListViewByDefault preference (#52914) * Backporting changes from WordPress/wordpress-develop#4891 * Site Editor: Open template parts in view canvas view mode (#52916) --------- Co-authored-by: Alex Lende <alex+github.com@lende.xyz> Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Co-authored-by: Mitchell Austin <mr.fye@oneandthesame.net> Co-authored-by: Jb Audras <audrasjb@gmail.com> Co-authored-by: Carolina Nymark <myazalea@hotmail.com> Co-authored-by: Robert Anderson <robert@noisysocks.com> Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: Lena Morita <lena@jaguchi.com> Co-authored-by: ramon <ramonjd@gmail.com>
Not passing any |
I'm looking into that separately, but I think small fix like #52916 is more suited for backports. |
|
I agree. What I'm trying to say is that by omitting
|
|
Here's a follow-up for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates the template parts link on the list page to open the record in edit mode. This matches the behavior in the
PageTemplatescomponent.Why?
I was working on #52884 and noticed the regression.
Testing Instructions