-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distraction Free Keyboard Shortcut: Fix notices in site editor #52867
Distraction Free Keyboard Shortcut: Fix notices in site editor #52867
Conversation
Size Change: -5 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Flaky tests detected in eb84483. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5641278847
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find. Goes to show it pays to ditch the mouse now and then 😄
Can confirm that on trunk I see the following:
Uncaught TypeError: isFeatureActive is not a function
On this branch:
2023-07-24.16.29.28.mp4
Thanks for the quick review! 🙇 |
I just cherry-picked this PR to the update/further-bugfixes-rc2 branch to get it included in the next release: 218ce78 |
* Fix image block v6 deprecation (#52822) * Remove incorrect comment * Add missing attribtes and supports * Add integration tests for the deprecation * Fix incorrect import * Fix fixtures * Image: Use the correct method for caption class in recent deprecation (#52853) * Distraction Free: Fix notices in site editor (#52867) * Distraction Free: Add missing command in site editor (#52868) * Site Editor: Fix the template parts link on the list page (#52891) * Return focus more from focus return hook (#52710) * Disambiguate "Import" button string. (#52907) * Disambiguate "Import" button string. * Add _x to import --------- Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> * My patterns page: Increase color contrast for the toggle group (#52678) * Update style.scss * Update style.scss * Check if object exists before accessing its properties. (#52870) * Check if object exists before accessing its properties. * Name anonymous functions * Update names * Sidebar: Restore Back buton 'go to parent' functionality (#52910) * Global styles revisions: display text if no revisions are found (#52865) * If somehow a user lands on the revisions panel when there are no revisions, show some helpful text rather than a loading spinner. Also, add an E2E test! * Updated unit tests to reflect resolver logic changes * Use existing string * Only open edit view when testing the revisions panel itself * ResizableFrame: Account for window resizing (#52697) * ResizableFrame: Account for window resizing * Don't memoize --------- Co-authored-by: Robert Anderson <robert@noisysocks.com> * Distraction Free: Fix conflict with showListViewByDefault preference (#52914) * Backporting changes from WordPress/wordpress-develop#4891 * Site Editor: Open template parts in view canvas view mode (#52916) --------- Co-authored-by: Alex Lende <alex+github.com@lende.xyz> Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Co-authored-by: Mitchell Austin <mr.fye@oneandthesame.net> Co-authored-by: Jb Audras <audrasjb@gmail.com> Co-authored-by: Carolina Nymark <myazalea@hotmail.com> Co-authored-by: Robert Anderson <robert@noisysocks.com> Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: Lena Morita <lena@jaguchi.com> Co-authored-by: ramon <ramonjd@gmail.com>
Thank you! 🙏🏻 |
What?
Distraction Free mode was added to the site editor in #51173, so will be part of WP 6.3.
This PR fixes the display of notices when toggling Distraction Free mode via the keyboard shortcut. Currently they are not displayed in the site editor when toggling via keyboard, but they are within the post editor.
Why?
Prior to this PR, the notices weren't displaying due to
isFeatureActive
attempting to be accessed fromdispatch
, resulting inTypeError: isFeatureActive is not a function
.How?
isFeatureActive
and replace withget
from the preferences store (we could accessisFeatureActive
from the edit-site store viauseSelect
, but the selector has been deprecated, so best to useget
from the preferences store instead).toggleFeature
from the edit-site store withtoggle
from the preferences store (toggleFeature
is deprecated so it was throwing a warning)Testing Instructions
CMD+SHIFT+\
on a Mac)Screenshots or screencast
The error and warning: