Patterns: use correct icon when searching with the slash inserter

[annezazu]

After creating a synced pattern and searching for it with the slash inserter, I noticed it defaults to the icon of the top block used in the pattern. This makes it hard to distinguish as different from other blocks:

For example, if I change the order to have a paragraph block first, the paragraph icon is used:

However, upon insertion, the icon switches appropriately in the toolbar:

[glendaviesnz]

It looks like this is an existing issue with reusable blocks. It would be nice to fix, but I don't think it is a must-have as not introduced by the patterns changes.

[glendaviesnz]

It looks like this was a deliberate design decision to show the topmost block icon https://github.com/WordPress/gutenberg/blob/trunk/packages/block-editor/src/store/selectors.js#L1989 so currently a feature not a bug 😃

[annezazu]

That feels strange to me 😅 @WordPress/gutenberg-design for some thoughts here. IMO we should be indicating they are patterns, along with sync state upon insertion.

[jameskoster]

I agree this can feel a bit strange :).

We're using the symbol icon in the Library, and I think we should be consistent. It should be purple too.

[glendaviesnz]

I think this should be pushed to post 6.3 - this is existing accepted behaviour so an enhancement rather than a bug. I agree that we should review it, but it is not critical and we have enough other things around patterns/resuable blocks to stabalise.

[jasmussen]

When we only had reusable blocks, and patterns were nascent, there might have been good context. I tend to agree with Jay that the new unification here suggests purple and symbol icon for the synced patterns at least.

[JosVelasco]

I agree patterns should be colored purple with the special icon, and I'd love to see unsynched patterns on that list when using the slash inserter. At least the custom patterns added by site users.

[glendaviesnz]

I'd love to see unsynched patterns on that list when using the slash inserter. At least the custom patterns added by site users.

@JosVelasco unsynced patterns were added to the / inserter here.

[glendaviesnz]

PR here to make all the icons the same.