Patterns: Allow inserting of unsynced patterns from quick inserter #52866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Enhancement
|
Ran out of time to get this properly tested and to sort the components changelog, etc. will get it finalised for review tomorrow. |
|
Size Change: +340 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e2d4f46. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5652214150
|
glendaviesnz
commented
Jul 24, 2023
| @@ -505,9 +505,14 @@ const applyWithDispatch = withDispatch( ( dispatch, ownProps, registry ) => { | |||
| ) { | |||
| __unstableMarkLastChangeAsPersistent(); | |||
| } | |||
| //Unsynced patterns are nested in an array so we need to flatten them. | |||
There was a problem hiding this comment.
I was initially flattening this in the autocomplete component, but decided there were more potential backwards compat issues modifying that public API.
It seems like this replaceBlocks API is currently only ever expecting an array with block objects rather than an array with a nested array of blocks, so this seems like a safe extension, but open to thoughts about whether this is the best approach.
glendaviesnz
added
[Type] Automated Testing
There was a problem hiding this comment.
Nice work @glendaviesnz 👍
This definitely helps clear up the confusion around patterns via the quick inserter.
✅ Both unsynced and synced patterns can be inserted by name via the quick inserter
✅ Only synced patterns appear under the synced patterns tab
❓ Not all my unsynced patterns were displayed under the My Patterns category in the Patterns inserter tab. No console errors are present either. Is this a known issue?
| Patterns | Inserter Tab |
|---|---|
 |
 |
All my unsynced patterns appear correctly in the quick inserter though.
Hmm, I am not seeing that @aaronrobertshaw, so not sure what is happening there: I added some additional patterns via the duplicate option in the site editor as it looks like that is what you also did given the naming, and they appeared in the inserter list ok. Maybe see if they are being returned by this selector or not as a starting point for debugging? |
|
@aaronrobertshaw it could also be worth checking if those patterns are not displaying on trunk, as in theory this PR doesn't touch anything that affects the display in that patterns preview tab. |
They are returned via this selector. They also appear to be still in the returned patterns within
These patterns aren't displaying in trunk either. I was only testing that tab as it was in the PR's test instructions.
Looking closer, I can actually see the patterns in that category panel's markup. Deleting one reveals the next. Also, #51947 introduced a typo in the category description text. |
yeh, it should have been tested as part of this PR for sure - just in case - and turns out it was worth doing to uncover another bug 😄 |
@aaronrobertshaw if you can work out what the issue is and work out a fix, feel free to push it to this PR if not too complex, or if you can work out how to replicate I am happy to help look for a fix. |
|
There's a Screen.Recording.2023-07-25.at.1.04.08.pm.mp4 |
|
False alarm, sorry. I was testing with a theme that threw a PHP warning which caused the issue discussed above. |
aaronrobertshaw
approved these changes
Jul 25, 2023
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allows adding of user added unsynced patterns from the quick inserter
Why?
Currently it is confusing that a user can add synced patterns and insert them from the quick inserter, but not unsynced patterns
How?
Adds the syncStatus to the inserter reusable blocks so unsynced patterns can be identified and handled differently
There is an additional PR which merges the Synced patterns inserter tab into the My patterns section of the Patterns tab.
Testing Instructions
Screenshots or screencast
quick-inserter.mp4