Library: Update section headings in pattern grid to account for template parts #51985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
Backport to WP 6.7 Beta/RC
|
Instead of removing the title / description, there may be an argument to make them contextual instead, e.g.: 
I don't have strong feelings either way. |
|
Size Change: +103 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
I've heard rumblings that the Library may be renamed to Patterns which would affect this PR, so I'm switching to draft. |
|
Not for 6.3, but as a follow-up we could probably implement a filter mechanism instead of separating into two groups. |
92 tasks
I made a related accessibility issue - Library: Add some context about the currently selected category to the main 'Library Content' region |
|
As long as template parts are not called patterns, I find it confusing that the heading, description and search placeholder includes "Pattern" at all. |
|
Quick note: We're exploring filtering by sync status, rather than separating the patterns into different sections, to aid pagination. This would effectively remove these section headings.
|
|
Yes, that's much better. |
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When browsing template parts in the Library, do not display the "Synced" heading and description.
Why?
The pattern grid splits synced and unsynced entries like so:
This is useful in contexts where patterns can be synced or not, such as the "Custom patterns" section.
However, template parts are always synced, so the heading is somewhat irrelevant.
Additionally, the description refers to the entries as "patterns", and it is not 100% clear that is the correct label for template parts.
Testing Instructions
Before
After