Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide parent selector when descendent of a disabled block is selected #51878

Closed
noisysocks opened this issue Jun 26, 2023 · 2 comments · Fixed by #52264
Closed

Hide parent selector when descendent of a disabled block is selected #51878

noisysocks opened this issue Jun 26, 2023 · 2 comments · Fixed by #52264
Assignees
Labels
[Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. [Type] Bug An existing feature does not function as intended

Comments

@noisysocks
Copy link
Member

It would be really nice (either here or in a follow-up) to also hide the parent selector when direct descendants of Post Content are selected. It doesn't really serve any meaningful purpose in this context:

Screenshot 2023-06-22 at 10 05 14

Originally posted by @jameskoster in #51780 (review)

@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended [Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. labels Jun 26, 2023
@noisysocks
Copy link
Member Author

noisysocks commented Jul 3, 2023

Something I realised while writing E2E tests is that if we do this we're removing one of the accessible ways to select the Post Content block. I think the only remaining way would be via the breadcrumbs. How much do you dislike this button, @jameskoster? 😀

@jameskoster
Copy link
Contributor

Something I realised while writing E2E tests is that if we do this we're removing one of the accessible ways to select the Post Content block.

The motivation for this change is the same as #51780. With that in mind, I'm not sure there's an accessibility issue here? When you're editing a page, there's basically no value in selecting the Post Content block because you can't do anything with it, and the parent selector feels like a distraction.

That said, I don't think it's a huge deal. Though nice to fix, if it's going to cause headaches perhaps it's something we circle back to later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. [Type] Bug An existing feature does not function as intended
Projects
None yet
3 participants