-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent block overlay on blocks with a 'contentOnly' editing mode #51780
Conversation
Size Change: +4 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
Flaky tests detected in 6805719f274663e9abb9e25f369dd0bc9634e9ad. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5342044147
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6805719
to
69f2506
Compare
What?
Fixes #51259.
Prevents the block overlay from appearing on blocks with an editing mode of
'contentOnly'
. For example the Post Content block when the user is focused on editing page content.Why?
The block overlay is redundant on blocks with an editing mode of
'contentOnly'
. There will be no block controls (toolbar items, etc.) once you select the block, so why push users towards selecting the block instead of its children?How?
Changes the logic in
__unstableHasActiveBlockOverlayActive
.Testing Instructions