Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footnotes block not removing formatting after block is deleted from the editor #52176

Closed
widoz opened this issue Jun 30, 2023 · 2 comments · Fixed by #52506
Closed

Footnotes block not removing formatting after block is deleted from the editor #52176

widoz opened this issue Jun 30, 2023 · 2 comments · Fixed by #52506
Assignees
@mcsf
Labels
[Block] Footnotes Affects the Footnotes Block [Type] Bug An existing feature does not function as intended

Comments

@widoz
Copy link
Contributor

widoz commented Jun 30, 2023

Description

Adding one or more footnotes in a page content the fn links format are not removed from the text if the footnotes block is deleted from the editor.

As additional note I see a strange behavior when I add a new note before an existing one, the block does not seems to reorder the internal list correctly.

Step-by-step reproduction instructions

For the block removing issue

  1. Create a new post or page and introduce a paragraph
  2. Select a portion of the paragraph and add a footnote
  3. Delete the Footnotes block

Result

  1. The fn elements are not removed from the paragraph
  2. The Front-end is not rendering the fn
  3. The Front-end is rendering asterisk

For the incorrect internal block list

  1. Create a new post or page and introduce a paragraph
  2. Select a portion of the paragraph and add a footnote
  3. Select another portion of the paragraph which exists before the already added footnote

Result

  1. The fn order looks correct but the block list order is incorrect and missing the new item

Screenshots, screen recording, code snippet

2023-06-30.15-05-42.mp4

And here how's look like on FrontOffice when the Footnotes block is not available.

image

Environment info

  • Gutenberg trunk up to date to dec307cff1 commit
  • Wordpress 6.3-beta2-56116
  • TwentyTwentyThree Theme (it's part of the wp-env)

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@karmatosed karmatosed added the [Type] Bug An existing feature does not function as intended label Jun 30, 2023
@karmatosed
Copy link
Member

I also see this as an issue; tested in Chrome using 16.1 (latest).

@karmatosed karmatosed added the [Block] Footnotes Affects the Footnotes Block label Jun 30, 2023
@mcsf mcsf mentioned this issue Jul 4, 2023
Merged
mcsf added a commit that referenced this issue Jul 4, 2023
@mcsf
Post editor: Require confirmation before removing Footnotes
681f2b3 
Context: #52176
mcsf added a commit that referenced this issue Jul 5, 2023
@mcsf
Post editor: Require confirmation before removing Footnotes (#52277)
e6426ea 
* Post editor: Require confirmation before removing Footnotes

Context: #52176

* BlockRemovalWarningModal: Limit width to 40rem

* Explain that footnotes are preserved. Add warning to Site Editor
tellthemachines pushed a commit that referenced this issue Jul 7, 2023
@mcsf @tellthemachines
Post editor: Require confirmation before removing Footnotes (#52277)
838485c 
* Post editor: Require confirmation before removing Footnotes

Context: #52176

* BlockRemovalWarningModal: Limit width to 40rem

* Explain that footnotes are preserved. Add warning to Site Editor
tellthemachines added a commit that referenced this issue Jul 7, 2023
@tellthemachines @SaxonF
@noisysocks @glendaviesnz @jameskoster @getdave @Mamaduka @draganescu @hellofromtonya @youknowriad @ellatrix @ramonjd @kevin940726 @richtabor @aaronrobertshaw @scruffian @stokesman @cbravobernal @ntsekouras @t-hamano @TimothyBJacobs @mcsf
Update/first pre beta 4 (#52400)
20ea9f1 
* add hint to show template part move (#52395)

* Page Content Focus: Ignore page content within a Query Loop block (#52351)

* Block Editor: Pass context and className props to editor.BlockEdit filter

* Page Content Focus: Ignore content blocks that are within a Query Loop

* Patterns: stop endless snackbars appearing (#52012)

* Patterns: Distinguish between theme patterns and template parts in category list (#52382)

* Allow opt out of auto-creation of Navigation fallback (#52319)

* Update welcome guide copy (#52282)

* Patterns: Update pattern copy (#52340)

* Post Title: The changes should be reflected when previewing a post (#52369)

* Update fixed block toolbar (#52123)

* update the icons for expanding and collapsing the fixed block toolbar

* hide the tools selector item in document tools for fixed toolbar preference

* reveal undo, redo and list view buttons

* tweaks for show icon labels and hide zoom out for top toolbar option

* improve the responsiveness of the fixed block toolbar

* remove the overflow rule - bad experiment

* update top toolbar test with the new label for buttons

* update the toolbar tests to account for moving the collapse button

* Drop PHP 5.6 CI jobs (#52345)

* Remove PHP 5.6 PHPUnit CI job
* Raise version in phpcs / WPCS

* Patterns: Add handling of sync status to the wp-admin patterns list page (#52346)

* Exit template focus when opening the W menu (#52235)

* wrap buttons (#52249)

* Update the behavior of the cached undo/redo stack (#51644)

Co-authored-by: Ella van Durpe <ella@vandurpe.com>

* Adjust top position (#52248)

* Patterns: add a hint about the rename of reusable blocks to menu and inserter  (#51771)

Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com>

* Site Editor: update headings hierarchy in the 'Manage all' screens (#52271)

* This commit:
- updates heading levels on the template and template part pages
- passes a `level` prop to Header from Page

* update h2 size

* Rolling back custom sizes

* Rolling back unnecessary classNames
There was a rogue space in trunk. Let's let it live

* Check randomizer experiment is enabled before rendering button (#52306)

* Hide parent selector when parent is 'disabled' or 'contentOnly' (#52264)

* Fix incorrect aria-describedby attributes for theme patterns (#52263)

* Patterns: rename sync_status and move to top level field on rest return instead of a meta field (#52146)

* Fix default block dimensions visibility (#52256)

* core/heading

* core/details

* core/list

* core/table

* core/video

* core/verse

* core/social-links

* core/site-title

* core/site-tagline

* core/site-logo

* core/post-time-to-read

* core/gallery

* core/code

* core/categories

* core/audio

* core/archives

* Patterns: Display all custom template part areas in sidebar nav (#52355)

* Revert phpcs back to PHP 5.6 (#52384)

Reverts phpcs PHP compatibility version back to 5.6.

* Check if experiment enabled fr this time (#52315)

* Navigation: Remove one preloaded endpoint (#52115)

* default to showing status (#52226)

* Command palette: rename (#52153)

* Revise use of “command menu” to “command palette”.

Dropping "global" where it was used as well.

* Find “command center” and replace with “command palette”

* Image block and behaviors: Fix some warnings (#52109)

* Fix first warning

* Fix second warning - dividing a NaN

* Turn off DFM for style book and style editing (#52117)

* Add confirmation step when deleting a Template (#52236)

* [Command Palette]: Remove suggestion for deleting templates/parts (#52168)

* Update stepper styling in Home template details panel (#51972)

* Update stepper styling

* Remove !important

* [Edit Post]: Add toggle fullscreen mode and list view commands (#52184)

* Style Book: Show tabs and make blocks clickable when entering edit mode from the Styles menu (#52222)

* Style Book: Show tabs and make blocks clickable when entering edit mode from the Styles menu

* Move lines

* !important (#52025)

* Navigation in Site View: Readd the edit button (#52111)

* Fix UnitControl crashing on regex control characters.

Units are now escaped using `escapeRegExp` before concatenating them into a regular expression.

Fixes #52211.
---------

Co-authored-by: Mitchell Austin <mr.fye@oneandthesame.net>

* Patterns: rename wp_block sync_status postmeta to wp_pattern_sync_status (#52232)

---------

Co-authored-by: Kai Hao <kai@kaihao.dev>

* Site Editor Frame: Ignore Spotlight in view mode (#52262)

* Guide: Place focus on the guide's container instead of its first tabbable (#52300)

* Guide: Place focus on the guide's container instead of its first tabbable

* Update CHANGELOG

* Post editor: Require confirmation before removing Footnotes (#52277)

* Post editor: Require confirmation before removing Footnotes

Context: #52176

* BlockRemovalWarningModal: Limit width to 40rem

* Explain that footnotes are preserved. Add warning to Site Editor

* Fix react-dropdown-menu version to avoid breaking change from one of … (#52356)

* Fix react-dropdown-menu version to avoid breaking change from one if its dependencies.

* Changelog update

* move changelog entry to the right place

* Update package-lock

---------

Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com>
Co-authored-by: Robert Anderson <robert@noisysocks.com>
Co-authored-by: Glen Davies <glendaviesnz@users.noreply.github.com>
Co-authored-by: James Koster <james@jameskoster.co.uk>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
Co-authored-by: Andrei Draganescu <me@andreidraganescu.info>
Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
Co-authored-by: Riad Benguella <benguella@gmail.com>
Co-authored-by: Ella van Durpe <ella@vandurpe.com>
Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Rich Tabor <hi@richtabor.com>
Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
Co-authored-by: Ben Dwyer <ben@scruffian.com>
Co-authored-by: Mitchell Austin <mr.fye@oneandthesame.net>
Co-authored-by: Carlos Bravo <37012961+c4rl0sbr4v0@users.noreply.github.com>
Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Timothy Jacobs <timothy@ironbounddesigns.com>
Co-authored-by: Kai Hao <kai@kaihao.dev>
Co-authored-by: Miguel Fonseca <150562+mcsf@users.noreply.github.com>
@mcsf mcsf mentioned this issue Jul 11, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 11, 2023
@mcsf
Copy link
Contributor

mcsf commented Jul 11, 2023

Until we add more complex configurations for Footnotes, such as the possibility of rendering them in the margins of the document, I believe that #52506 is an adequate solution to this problem. I'd like to merge that fix as soon as possible (regardless of whether it should close this issue).

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcsf mcsf

Labels
[Block] Footnotes Affects the Footnotes Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow editing existing footnote from RichText formats toolbar WordPress/gutenberg
4 participants
@mcsf @karmatosed @widoz @priethor