Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Library: Automatically switch to installed tab after successful upload of fonts. #54779

Open
Tracked by #60528
madhusudhand opened this issue Sep 25, 2023 · 3 comments · May be fixed by #55975
Open
Tracked by #60528

Font Library: Automatically switch to installed tab after successful upload of fonts. #54779

madhusudhand opened this issue Sep 25, 2023 · 3 comments · May be fixed by #55975
Assignees
@madhusudhand
Labels
[Feature] Font Library [Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@madhusudhand
Copy link
Member

Description

Currently on upload of a font (#54655), the tab page isn't automatically switch to Library tab.

Read more about this ask in this comment

Step-by-step reproduction instructions

  1. Open font library modal from global styles in the editor.
  2. Switch to Upload tab and upload a font.
  3. Observe that it shows a success message, but doesn't switch to Library tab automatically.

Screenshots, screen recording, code snippet

No response

Environment info

  • Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@madhusudhand madhusudhand mentioned this issue Sep 25, 2023
Merged
@madhusudhand
Copy link
Member Author

Requires #53960 to be merged.

@madhusudhand madhusudhand added the [Type] Enhancement A suggestion for improvement. label Sep 25, 2023
@properlypurple properlypurple added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Fonts API labels Sep 25, 2023
@annezazu annezazu added [Feature] Typography Font and typography-related issues and PRs and removed [Feature] Fonts API labels Sep 25, 2023
@matiasbenedetto matiasbenedetto mentioned this issue Sep 26, 2023
Closed
14 tasks
@ironprogrammer ironprogrammer mentioned this issue Sep 29, 2023
Closed
@mikachan mikachan mentioned this issue Nov 6, 2023
Closed
25 tasks
@madhusudhand madhusudhand linked a pull request Nov 8, 2023 that will close this issue
Open
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 8, 2023
@griffbrad
Copy link

Just noting that @chad1008 landed the migration to Tabs in #57181. That was originally part of #55975, which stalled out due to some accessibility concerns around the focused element following the successful upload/installation of a font.

@madhusudhand
Copy link
Member Author

Part of the code split into #58178 and accebility concerns are addressed here

@creativecoder creativecoder mentioned this issue Apr 6, 2024
Open
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madhusudhand madhusudhand

Labels
[Feature] Font Library [Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch tabs after successful upload of fonts WordPress/gutenberg
5 participants
@colorful-tones @griffbrad @madhusudhand @annezazu @properlypurple