Font Library: make the notices manually dismisable #58178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhusudhand
added
[Type] Feedback
madhusudhand
changed the title
|
Size Change: -77 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
The code looks good :)
I'm unsure if this is the desired behavior, particularly about removing the auto-dismiss after 5 seconds.
@jasmussen I would like to have your input, please.
|
This is also accomplished in #58180 which also does a few additional things. It was because of @jasmussen 's feedback noted in the description that the auto-dismiss was removed. So I think he'll be for it. :) |
madhusudhand
added
[Type] Enhancement
|
I think there's something about how these notices behave in general that I think we can polish and refine in the beta period, but should not block small refactors like these. 👍 👍 |
|
Thanks @madhusudhand! Closing in favour of #58180. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It addresses the following suggestion from here
How?
Notices are set to disappear automatically after
5 secbased on a timer. It is removed here.Testing Instructions
Screenshots or screencast