-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font Library: add option to revoke access to Google Fonts #54826
Comments
Thanks for proposing this feature. I added under "Needs discussion" in stage 3 tracking issue. |
Technically this would be simple to implement but we would need to add an UI element if we decide to implement it. @jasmussen I would like to have your input about this. |
Linking a closely related issue: #58774 |
How's this ellipsis menu? By the way, be mindful of the details in the existing mockups, there's a lot that's diverging in trunk at the moment: It's possible I'm missing context from other reviews, so correct me if I'm wrong. But the connect box should be vertically centered, I'd avoid the "Google Fonts" heading (the introductory paragraph is sufficient), the width, height and padding of the box is off, the line-height of the warning is wrong, and the "Allow access" button should be centered, or full-width. I realize there's a separate issue for changing the text, that's fine. And finally, a comma is missing from the introductory paragraph. |
If we implement this how hard would it be to make it provider agnostic. So say Theme A bundles a specific provider of fonts, could we make the UI able to revoke access to that collection also? The primary objective should be to allow Google Fonts to be revoked in 6.5 though 👍 |
Linking this issue here as closely related: #58774 |
So this has been implemented already, Any reason we're keeping the issue open? |
Closing this issue as fixed by: #59205 |
What problem does this address?
Font Library > Install shows a very cautious warning about allowing access to Google Fonts, but there's no way to revoke that access once it's granted.
What is your proposed solution?
There needs to be an action button that revokes access to Google Fonts and brings the modal back to its initial state.
The text was updated successfully, but these errors were encountered: