Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: add terms and conditions #58774

Open
Tracked by #60528
matiasbenedetto opened this issue Feb 7, 2024 · 6 comments
Open
Tracked by #60528

Font Library: add terms and conditions #58774

matiasbenedetto opened this issue Feb 7, 2024 · 6 comments
Labels

Comments

@matiasbenedetto
Copy link
Contributor

matiasbenedetto commented Feb 7, 2024

What problem does this address?

  • Give users a way to accept or reject loading the data from a registered font collection.
  • Give font collection creators the ability to add terms and conditions text to inform users about that.

What is your proposed solution?

  • Add terms and conditions field in the font collection.
  • Render the terms and conditions from a font collection in the frontend.
  • All the font collections need users' permission to load the assets.
  • Make the Google fonts permission dialog font collection agnostic.

Core trac ticket: https://core.trac.wordpress.org/ticket/60593

@getdave
Copy link
Contributor

getdave commented Feb 12, 2024

@matiasbenedetto If WordPress (e.g. Google Fonts) or Themes are bundling Font Families, it would be good to allow users to:

  • be informed about the conditions of usage
  • reject those Collections

I believe blocking registration of fonts can be done via filters so technically it is possible but requires technical knowledge.

How difficult is it going to be to add a UI to allow users to revoke collections? Have we made any plans for implementing this during the 6.5 cycle?

@fabiankaegy @colorful-tones @youknowriad For your thoughts also. We are entering Beta 1, but I think if this is deemed sufficiently important it's passable to allow the work to be completed during the Beta phase.

@youknowriad
Copy link
Contributor

I think the UI is already in place, you have to accept the license the first time you want to use google fonts (first time you open the tab) and even after than, you have to "install" fonts to work.

@getdave
Copy link
Contributor

getdave commented Feb 12, 2024

I'm wondering whether the behaviour you describe is specific to Google Fonts?

@matiasbenedetto
Copy link
Contributor Author

The ask for permission and explanation about the behavior is already in place, but that's specific to the Google Fonts collection. In this ticket, I think we should discuss if we need to generalize by adding the ability to the font collection to provide texts with their license or similar.

@youknowriad
Copy link
Contributor

I think it would be good to generalize indeed but I don't believe it's a 6.5 requirement.

@colorful-tones
Copy link
Member

I think it would be good to generalize indeed but I don't believe it's a 6.5 requirement.

Yeah, totally agree. Not a 6.5 requirement. However, I would love to see the addition of a UI to allow users to revoke a Collections acceptance (Local Storage) for 6.5. That is captured in #54826 , and yes it would be nice to see it implemented in a generalized nature so that other potential collections could leverage the same method.

@matiasbenedetto matiasbenedetto changed the title Font Library: font collections license and permission Font Library: add terms and conditions Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants