Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Lightbox (expand on click) does not work in WordPress 6.4 Beta 1 #54869

Closed
burnuser opened this issue Sep 27, 2023 · 8 comments
Closed

New Lightbox (expand on click) does not work in WordPress 6.4 Beta 1 #54869

burnuser opened this issue Sep 27, 2023 · 8 comments
Labels
OS Issues Issues or PRs that are related to OS specific problems [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@burnuser
Copy link

Description

No Lightbox at all
Maybe (?) in conjunction with the usual layout error of Beta version, seen in navigation:
image

Step-by-step reproduction instructions

  1. Make a fresh WordPress installation.
  2. set "sample page" as Homepage
  3. Install Beta Plugin
  4. select Bleeding Edge version
  5. update wordpress
  6. insert an image
  7. select "expand on click"
  8. view page
  9. see image and try to click => ?

Screenshots, screen recording, code snippet

Regular page without Lightbox:
image

Page with "expand on click":
image

Click on grey area opens image at the bottom of the page:
image

Environment info

  • WordPress: 6.4-beta1-56730
  • PHP: 8.1.23
  • Server: nginx/1.16.0
  • Database: mysqli (Server: 8.0.16 / Client: 8.1.23)
  • Browser: Chrome 117.0.0.0 (Windows 10/11)
  • Theme: Twenty Twenty-Three 1.2
  • MU-Plugins: Keine aktiviert
  • Plugins:
    • WordPress Beta Tester 3.5.4

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@michalczaplinski michalczaplinski added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block [Feature] Interactivity API API to add frontend interactivity to blocks. labels Sep 27, 2023
@jordesign
Copy link
Contributor

Hey @burnuser - I'd seen that general layout error in testing 6.2 as well - does it (or the lightbox issue) go away when the Gutenberg plugin is installed and active?

@jordesign
Copy link
Contributor

In my testing of the beta - I'm getting the expand/lightbox operating as expected - so I wonder if there's something else at play here. We may need to narrow things down further.

@jordesign jordesign added the Needs Testing Needs further testing to be confirmed. label Sep 27, 2023
@burnuser
Copy link
Author

@jordesign

1.) Test with Gutenberg to Beta added and activated:
a) general layoutbug is gone
b) lightbox works

Gutenberg deactivated (Beta alone):
both errors are back again

2.) Test with fresh environment: WP 6.3.1 + Gutenberg:
no layoutbug + lightbox works

Result: problem must be located in Beta

@michalczaplinski
Copy link
Contributor

cc: @artemiomorales

@artemiomorales
Copy link
Contributor

Has anyone else been able to reproduce this? I'm unable to replicate.

CC
@burnuser
@michalczaplinski

@carolinan
Copy link
Contributor

While not a long-term solution, does it work if you set define( 'SCRIPT_DEBUG', true ); in wp-config?

@burnuser
Copy link
Author

Test with local WP environments (which I - and many other people around the world - use for development and testing) - using http:
Laragon: https://laragon.org/
Local: https://localwp.com/
=> both show the described bugs

Test with 2 Online environments - using https:
InstaWP
TasteWP
=> no bug visible

@priethor priethor changed the title New Lightbox (expand on click) does not work in Beta 1 New Lightbox (expand on click) does not work in WordPress 6.4 Beta 1 Sep 29, 2023
@bph bph moved this from Triage to Needs Dev / Todo in WordPress 6.4 Editor Tasks Sep 30, 2023
@t-hamano
Copy link
Contributor

t-hamano commented Oct 2, 2023

Considering that this problem occurs on a site built on a local Windows OS machine, does not occur on a site built using InstaWP, etc., and the screenshot posted in the issue, it is the same as the problem reported in #54849. Therefore, I would like to close this issue.

A description of the cause for this problem and a patch to resolve it can be found in this core ticket: https://core.trac.wordpress.org/ticket/59489

@t-hamano t-hamano closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2023
@github-project-automation github-project-automation bot moved this from Needs Dev / Todo to Done in WordPress 6.4 Editor Tasks Oct 2, 2023
@t-hamano t-hamano added [Type] Regression Related to a regression in the latest release [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed OS Issues Issues or PRs that are related to OS specific problems and removed Needs Testing Needs further testing to be confirmed. [Block] Image Affects the Image Block [Feature] Interactivity API API to add frontend interactivity to blocks. labels Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS Issues Issues or PRs that are related to OS specific problems [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
No open projects
Status: Done
Development

No branches or pull requests

6 participants