Set default image behavior to expand on click (lightbox)

[richtabor]

To showcase the new lightbox functionality in core, I propose we set lightbox (Expand on click) on for images.

• Update theme.json to reflect lightbox global setting (source)
• Update patterns that should have lightbox off, like clients

[carolinan]

I would strongly recommend against this because the lightbox has multiple issues.
If the lightbox is improved and is accessible in a later release, the theme can be extended with new patterns.

[richtabor]

I would strongly recommend against this because the lightbox has multiple issues.

Can you give sources? This feature is currently planned for 6.4.

[carolinan]

The feature doesn't have its own label, here are some:

Tracking issue: WordPress/gutenberg#51132

WordPress/gutenberg#54921
WordPress/gutenberg#54869
WordPress/gutenberg#54916
WordPress/gutenberg#54682
WordPress/gutenberg#54635

There are accessibility issues that I have run into and that I know have been discussed, but right now, I cannot find specific issues for them; they may only be mentioned in other discussions.
For example, alt texts are not announced, so the only information a screen reader user gets is "Enlarge image" followed by "close"

[artemiomorales]

For example, alt texts are not announced, so the only information a screen reader user gets is "Enlarge image" followed by "close"

@carolinan Thanks for catching this. This had been working previously but had regressed in a recent shuffle of the code. Here's a PR fixing it.

I haven't come across other accessibility issues or been made aware of any. As of the last time accessibility reviewers took a look, it also seemed to be working well, so would appreciate links to those discussions if you or others could surface them 🙏

As far as enabling the lightbox by default goes, I personally don't think that's necessary for core and it can instead be showcased via themes, though am happy to hear other opinions and further thoughts on that.

[richtabor]

As far as enabling the lightbox by default goes, I personally don't think that's necessary for core and it can instead be showcased via themes, though am happy to hear other opinions and further thoughts on that.

Agreed! That's why I'm proposing it here in TT4.

[artemiomorales]

Agreed! That's why I'm proposing it here in TT4.

Got it! Pardon, I missed that this is in the Twenty Twenty Four repo 😆

[luminuu]

@carolinan Have you followed the development of the lightbox recently and can you tell us if the A11Y issues have been worked on?

[carolinan]

Only some are worked on https://github.com/WordPress/gutenberg/issues?q=is%3Aopen+is%3Aissue+author%3Aafercia+label%3A%22%5BBlock%5D+Image%22
During a test on Friday, Andrea found more problems with the usability, that does not have issues opened yet. I believe he plans to write the dedicated issues today.

[richtabor]

There is a follow-up PR to lightbox ready for testing, but it's an exploration; not a matter-of-fact. Worth a look for sure though.

[richtabor]

Going to close this as not-planned. The lightbox feature needs a bit more attention before we should enable it by default out-of-the-box. This is a good PR #530 to showcase the how though, for future reference.

[MaggieCabrera]

Let's make a point of including a patch for TT4 on 6.5 including this change