-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Rename Menu Item to standard menu item not Plugin #55338
Labels
[Type] Performance
Related to performance efforts
Comments
Great idea! |
This is on my radar for the 6.5 cycle. |
This was referenced Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Update: when implementing this we can draw on a bug fix which went directly into the
wp/6.4
branch.As suggested by @jsnajdr let's make the "Rename" menu item into a default item within the menu as per
BlockLockMenuItem
:gutenberg/packages/block-editor/src/components/block-settings-menu-controls/index.js
Line 83 in ef21f20
We can then remove the filter thus avoiding any perf concerns with the Plugin-based approach.
I think what you suggest above is the most pragmatic option for now. This could be actioned in tandem with the follow up in #55194 to make metadata a default global attribute.
Originally posted by @getdave in #55250 (comment)
The text was updated successfully, but these errors were encountered: