Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Rename Menu Item to standard menu item not Plugin #55338

Closed
getdave opened this issue Oct 13, 2023 · 2 comments · Fixed by #56386
Closed

Convert Rename Menu Item to standard menu item not Plugin #55338

getdave opened this issue Oct 13, 2023 · 2 comments · Fixed by #56386
Assignees
Labels
[Type] Performance Related to performance efforts

Comments

@getdave
Copy link
Contributor

getdave commented Oct 13, 2023

Update: when implementing this we can draw on a bug fix which went directly into the wp/6.4 branch.

As suggested by @jsnajdr let's make the "Rename" menu item into a default item within the menu as per BlockLockMenuItem:

We can then remove the filter thus avoiding any perf concerns with the Plugin-based approach.

Alternatively, the rename UI doesn't need to be a plugin. It could be hardcoded directly into the Block Settings Menu, like, for example, BlockLockMenuItem is.

I think what you suggest above is the most pragmatic option for now. This could be actioned in tandem with the follow up in #55194 to make metadata a default global attribute.

Originally posted by @getdave in #55250 (comment)

@getdave getdave self-assigned this Oct 13, 2023
@getdave getdave added the [Type] Performance Related to performance efforts label Oct 13, 2023
@Mamaduka
Copy link
Member

Great idea!

@getdave
Copy link
Contributor Author

getdave commented Nov 7, 2023

This is on my radar for the 6.5 cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Performance Related to performance efforts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants