Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport Block Renaming Default Attributes #55194

Closed
getdave opened this issue Oct 10, 2023 · 2 comments
Closed

Backport Block Renaming Default Attributes #55194

getdave opened this issue Oct 10, 2023 · 2 comments
Assignees
@getdave
Labels
[Feature] Block API API that allows to express the block paradigm. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Oct 10, 2023 •
edited
Loading

As per discussion in https://github.com/WordPress/gutenberg/pull/54426/files#r1334343353 let's make metadata a standard attribute for all blocks in the same way as for lock attribute.

https://github.com/WordPress/wordpress-develop/blob/a80165b78f2367f92e2eff679c4e035d1c5bdc7c/src/wp-includes/class-wp-block-type.php#L248-L250

Originally posted by @getdave in #54426 (comment)
@getdave getdave self-assigned this Oct 10, 2023
@getdave getdave moved this from Backlog to Todo in Automattic team Ignite's project board Oct 10, 2023
@getdave getdave mentioned this issue Oct 10, 2023
Merged
@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Feature] Block API API that allows to express the block paradigm. labels Oct 11, 2023
This was referenced Oct 13, 2023
Merged
Closed
@getdave getdave mentioned this issue Oct 26, 2023
Closed
4 tasks
This was referenced Oct 30, 2023
Closed
Closed
@gziolo
Copy link
Member

gziolo commented Nov 3, 2023

@ockham opened PR WordPress/wordpress-develop#5608 to set metadata as a global attribute in WordPress core.

@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Nov 3, 2023
@ockham
Copy link
Contributor

ockham commented Nov 6, 2023

@ockham opened PR WordPress/wordpress-develop#5608 to set metadata as a global attribute in WordPress core.

Committed to Core in https://core.trac.wordpress.org/changeset/57068.

@ockham ockham closed this as completed Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

Labels
[Feature] Block API API that allows to express the block paradigm. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Block Types: Add metadata global attribute ockham/wordpress-develop
4 participants
@ockham @getdave @gziolo @jordesign