Block Types: Add metadata global attribute
#5608
Closed
+28
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
ockham
changed the title
metadata global attribute
Mamaduka
approved these changes
Nov 3, 2023
gziolo
reviewed
Nov 3, 2023
gziolo
approved these changes
Nov 3, 2023
16 tasks
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
|
Thanks all! I also made sure to test this change with Gutenberg installed and activated, to make sure this change wouldn't commit with code from WordPress/gutenberg#54426 ✅ (Fortunately, the latter has a number of Committed to Core in https://core.trac.wordpress.org/changeset/57068. |
|
I was very pleased to return to work and find this completed. Thank you so much 🙇 |
This was referenced Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For use cases such as allowing the user to assign custom names to blocks or for making Block Hooks work with user-modified templates/parts/patterns (
#59646), there's a requirement for a new global attribute (i.e. an attribute that can be added to all and any blocks) to hold that sort ofmetadata.See #2615 for precedent for registering a global attribute.
Spun off from #5523.
Fixes WordPress/gutenberg#55194.
Trac ticket: https://core.trac.wordpress.org/ticket/59797
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.