Register 'lock' attribute for every block on the server #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
changed the title
Mamaduka
commented
Apr 21, 2022
| * @since 6.0.0 | ||
| * @var array | ||
| */ | ||
| const CORE_ATTRIBUTES = array( |
There was a problem hiding this comment.
I couldn't decide between CORE_ATTRIBUTES and BUILTIN_ATTRIBUTES. I'm open to name suggestions :)
There was a problem hiding this comment.
I couldn't decide between
CORE_ATTRIBUTESandBUILTIN_ATTRIBUTES.
How about GLOBAL_ATTRIBUTES or GLOBAL_BLOCK_ATTRIBUTES?
|
The issue is from WP 5.9, but it's more visible now that we have UI. |
gziolo
reviewed
Apr 22, 2022
gziolo
reviewed
Apr 22, 2022
peterwilsoncc
requested changes
Apr 25, 2022
| * @since 6.0.0 | ||
| * @var array | ||
| */ | ||
| const CORE_ATTRIBUTES = array( |
There was a problem hiding this comment.
I couldn't decide between
CORE_ATTRIBUTESandBUILTIN_ATTRIBUTES.
How about GLOBAL_ATTRIBUTES or GLOBAL_BLOCK_ATTRIBUTES?
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
gziolo
reviewed
Apr 25, 2022
|
Let's plan to land this patch tomorrow before WP 6.0 Beta 3. I see two remaining tasks:
|
Mamaduka
commented
Apr 26, 2022
gziolo
approved these changes
Apr 26, 2022
|
Committed with https://core.trac.wordpress.org/changeset/53268. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports changes from WordPress/gutenberg#40468.
The
lockattribute needs to be supported by every block, but currently, it is only done on the client site. As a result, it was causing block rendered API requests to fail when blocks are locked.PR updates the
WP_Block_Typeclass to handle built-in/core attribute registration.Trac ticket: https://core.trac.wordpress.org/ticket/55567
cc @gziolo, @hellofromtonya
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.