Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar styles are broken in the post publish panel #59966

Closed
octaedro opened this issue Mar 18, 2024 · 7 comments · Fixed by #59990
Closed

Calendar styles are broken in the post publish panel #59966

octaedro opened this issue Mar 18, 2024 · 7 comments · Fixed by #59990
Assignees
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Comments

@octaedro
Copy link

Description

The calendar styles in the post-publish panel, when expanding the scheduling section, look broken.

Step-by-step reproduction instructions

  1. In a brand new JN site, install GB 17.9.0
  2. Go to Posts > Add New Post
  3. Add a Title and press Publish.
  4. The post-publish panel will be visible.
  5. Press Publish: Immediately.
  6. The calendar will be visible, but it will be cut.

Screenshots, screen recording, code snippet

Screen Recording on 2024-03-18 at 04-29-38

Environment info

It's happening on GB 17.9.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@octaedro octaedro added the [Type] Bug An existing feature does not function as intended label Mar 18, 2024
@annezazu annezazu added the General Interface Parts of the UI which don't fall neatly under other labels. label Mar 18, 2024
@annezazu annezazu moved this to ❓ Triage in WordPress 6.5 Editor Tasks Mar 18, 2024
@annezazu
Copy link
Contributor

I can replicate this with 6.5 RC2. Adding to the board.

@t-hamano
Copy link
Contributor

I believe this issue is a regression caused by #55502. This can be reproduced for the first time in WP6.5.

In #55502, the button size was increased from 28px to 32px, which seems to have caused it to overflow the sidebar width.

Below is a screenshot on Windows OS, but the Sunday column is completely hidden.

image

The following is a screenshot from WP6.4, and although the overflow itself does not occur, the calendar elements are sticking out of the grid layout, so some fundamental adjustment will be required.

image

@getdave
Copy link
Contributor

getdave commented Mar 19, 2024

I believe this issue is a regression caused by #55502.

Can we revert the change to day sizing introduced in that PR and see if it fixes? We can then ship that fix in 6.5 and seek a more robust solution to enlarging the text size during 6.6 cycle.

@getdave getdave moved this from ❓ Triage to 📥 Todo in WordPress 6.5 Editor Tasks Mar 19, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 19, 2024
@t-hamano
Copy link
Contributor

I submitted a PR: #59990

@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.5 Editor Tasks Mar 19, 2024
@t-hamano
Copy link
Contributor

@getdave #59990, which fixes this issue, has been merged. We didn't make it in time to ship to RC3, but I don't think this issue is critical, so 6.5.1 might be fine.

@getdave getdave moved this from ✅ Done to 🐛 Punted to 6.5.1 in WordPress 6.5 Editor Tasks Mar 19, 2024
@getdave
Copy link
Contributor

getdave commented Mar 19, 2024

I'm happy punting this to 6.5.1 - cc'ing @fabiankaegy and @annezazu for confirmation.

@annezazu
Copy link
Contributor

I'm okay with that 👍🏼 The functionality still works so it feels less mission critical.

@t-hamano t-hamano removed the [Status] In Progress Tracking issues with work in progress label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
Status: 🐛 Punted to 6.5.1
Development

Successfully merging a pull request may close this issue.

4 participants