Fix DayButton dot position and expand Button area #55502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @kurudrive! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
kurudrive
changed the title
t-hamano
added
[Package] Components
ajitbohra
reviewed
Dec 18, 2023
mirka
approved these changes
Dec 18, 2023
|
Looks like a good little improvement. |
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
* Fix DatButton dot position and expand Button area * add change log * Move changelog --------- Co-authored-by: Lena Morita <lena@jaguchi.com>
This was referenced Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adjustment of the dot position on DayButton and expansion of the button area.
Why?
In the DatePicker, the dot indicating the publish date is too close to the background circle, making it look unappealing.
issue : #51966
How?
I shifted the dot's position 2px upward and slightly expanded the button area.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
After