Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider including gutenberg.pot in the repository #604

Closed
nylen opened this issue May 2, 2017 · 2 comments
Closed

Reconsider including gutenberg.pot in the repository #604

nylen opened this issue May 2, 2017 · 2 comments
Assignees
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended

Comments

@nylen
Copy link
Member

nylen commented May 2, 2017

In general a source control repository should not store files that are derived from other source files. With almost every code change we make, there are corresponding changes in gutenberg.pot. It's easy to miss updating this file (see #603 for an example), and I think we really only need it when we do a build. In that case, shouldn't we remove it from the repository (ignore it) and just cause it to be generated as part of the build step?

One thing that's not clear to me is where and how the actual translations of our strings will be stored, but I think this would be outside of source control as well.

@nylen nylen added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Question Questions about the design or development of the editor. labels May 2, 2017
@aduth
Copy link
Member

aduth commented May 2, 2017

This has become enough of a pain point that I'd agree it's probably best to ignore in the repository. Alternatively I'd considered having a bot to generate these automatically upon each commit, but there's not a good core reconciliation story there.

@aduth aduth self-assigned this May 2, 2017
@nylen nylen added [Type] Bug An existing feature does not function as intended and removed [Type] Question Questions about the design or development of the editor. labels May 2, 2017
@nylen
Copy link
Member Author

nylen commented May 2, 2017

Changed this to a bug because earlier today it was the reason that #603 had merge conflicts with master. I fixed it on that PR, but still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants