Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generated gutenberg.pot file from repository #614

Merged
merged 1 commit into from
May 3, 2017

Conversation

aduth
Copy link
Member

@aduth aduth commented May 2, 2017

Closes #604

This pull request seeks to ignore the languages/gutenberg.pot in the repository, instead moving string extraction to a standalone npm script gettext-strings.

Testing instructions:

Verify that the languages/gutenberg.pot file is not included in the repository, but that it can still be generated by running npm run gettext-strings.

@aduth aduth added the [Type] Build Tooling Issues or PRs related to build tooling label May 2, 2017
@nylen
Copy link
Member

nylen commented May 2, 2017

I notice this is no longer included in the regular build or npm run dev. Is this OK?

Copy link
Member

@nylen nylen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah! Another merge conflict due to .pot changes, this time in #594. Let's ship this and refine later if needed.

@aduth
Copy link
Member Author

aduth commented May 3, 2017

I notice this is no longer included in the regular build or npm run dev. Is this OK?

Should be fine. WordPress only tries to use a .mo file from wp-content/languages or gutenberg/languages for loading of actual strings. The template file is what we'll want to integrate into GlotPress at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants