-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure pattern categories always render in the Inserter #61320
Comments
This issue feels very reminiscent of #60991, enough that if we can do this:
It would likely solve both. We might refine this to "nearest insertable location" rather than "at the end". But wouldn't that mainly be the case? And if we can solve this, do we need loading placeholders or messages? |
CC: @jameskoster |
I removed the needs design label. I think it's fine if the pattern inserter says "No results found" when there are no patterns. Although if there are patterns insertable, you should see the pattern categories available. That we should resolve. |
It seems like this is already fixed. When there is no block selected, we can still use the inserter and see the pattern categories, the pattern is inserted at the end of the post. I'm going to close this issue, but I would appreciate if someone could double-check if I'm missing anything please feel free to reopen. |
What problem does this address?
Since #61108, there are several conditions under which the patterns tab doesn't display patterns:
remove_theme_support( 'core-block-patterns' );
In each of these cases we show this message in the patterns tab:
What is your proposed solution?
We should treat each of these situations differently:
It would be useful to have designs for these states. cc @jasmussen @richtabor
The text was updated successfully, but these errors were encountered: