Zoom Out: Pass the section root ID to the inserter #61464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -35 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
scruffian
added
[Type] Bug
scruffian
requested review from
ellatrix,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
force-pushed
the
update/root-client-block-in-zoomed-out
branch
from
a34b09a to
d1931c1
Compare
|
Flaky tests detected in d1931c1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8995820888
|
draganescu
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #61428. Uses the section root ID as an insertion point for the Sidebar Inserter, instead of the root client id, if it exists, so that blocks and patterns get inserted at the correct location. Part of #61320.
Why?
If no block is selected we should still be able to insert patterns and blocks, just at the end of the page, or at the end of the section root.
How?
Gets the section root ID if it exists and passes into the sidebar inserter.
Testing Instructions
Screenshots or screencast