Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Inspector: Move taxonomy term select UI (categories + tags) to updated summary panel #61852

Open
jameskoster opened this issue May 22, 2024 · 8 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Follow-up to #59689

Currently taxonomy selection occurs in dedicated panels. Ideally these should follow the Discussion and Author panels into the Summary section:

Current Proposed
Screenshot 2024-05-22 at 09 49 32 Screenshot 2024-05-22 at 09 51 32
@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels May 22, 2024
@Mamaduka
Copy link
Member

It would be nice to account for multiple, dozen and more designs for these panels from the start.

I've done my fair share of work on these components and have seen people assigning 30+ tags to a post.

@jameskoster
Copy link
Contributor Author

@Mamaduka there's some discussion about that here: #61492 (comment)

@Mamaduka
Copy link
Member

@jameskoster, I'm following that discussion as well.

These panels are a bit different from the others in that area as they have to display multiple values, unlike others, where the panel trigger button usually has a single string value.

@jameskoster
Copy link
Contributor Author

Could the label not be a truncated, comma separated list of all values?

cats-and-tags

Alternatively, perhaps something like;

  • 0 tags: [Select tags]
  • <3 tags: [Tag One, Tag Two]
  • ≥3 tags: [5 tags]
cats-and-tags

If we decide it's necessary that all terms are visible then a more comprehensive solution could be an autocomplete/combobox component. Similar to what we have now, but with some visual tweaks to make it more at home inside the summary panel:

cats-and-tags

@jameskoster jameskoster added the Needs Design Feedback Needs general design feedback. label May 22, 2024
@jasmussen
Copy link
Contributor

I'd agree, not sure it's good to consolidate everything into this card. Notably tags feels best omitted from here, same with categories and custom taxonomies. And should sticky move into "Status"?

@jameskoster
Copy link
Contributor Author

Notably tags feels best omitted from here

@jasmussen Where do you think they should live?

@jasmussen
Copy link
Contributor

My instinct is that the summary panel as a whole works well as a colophon, in terms of the size and contents without tags and categories. And that as soon as you add those, it grows vertically to the point that it loses some of that "overview" feeling, and starts becoming more of an everything-panel. It's also not clear it improves the usability of the individual controls as they exist in panels today.

That's not to say it can't work. But just that the panel as it exists in trunk, even with existing tag and category panels, would be a big refinement and change to ship in 6.6. We could then, early in the 6.7 phase, decide based on 6.6 feedback whether absorbing those remaining panels is a natural evolution of the work, or whether they have better utility as separate panels.

So I'd keep the panels as they are.

@jameskoster
Copy link
Contributor Author

And that as soon as you add those, it grows vertically to the point that it loses some of that "overview" feeling

Just to note, the plans originally set out in #59689 included combining status + publish date, and moving template to a 'Design' panel. So even with categories and tags there would only be 6 items here.

A reminder of what we're shooting for:

Screenshot 2024-05-23 at 14 15 10

Some of those are longer-term changes though. So waiting for 6.7 seems reasonable even if (imo) it leaves the summary panel feeling a little unfinished for 6.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
Status: Needs Dev
Status: 🏈 Punted to 6.7
Development

No branches or pull requests

3 participants