-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue: Normalize details
view with inspector controls in site editor
#59689
Comments
details
view with inspector controls in site editordetails
view with inspector controls in site editor
Hi @jameskoster, The new "Level" option will include all of the current "Page Attributes" section? E.g. when clicked it will open a modal that allows the user to choose both the page parent and the order? |
The "Edit exercerpt" is a normal action when clicked it will open a modal where the user can change the exercerpt that will also work on dataviews? |
@jorgefilipecosta good questions :) The "Level" option would open a popover where you can select a parent page. "Organization" might be a better label:
I think it's probably okay to start with a modal. But if it's not too much trouble then it might easier if users could simply click to add/edit excerpts. Then we could remove 'Edit excerpt' to make that menu a bit shorter: What do y'all think? |
@jameskoster could we just start with two separate attributes in summary panel? "Organisation" may be confused with team/account, and parent seems important enough to be highlighted as its own thing.
|
Does this issue include the work to remove the existing details views once the gaps are closed or should we spin up a separate issue for that? |
It could be a standalone ticket, but I think for now it could be just a task here:
|
I've seen feedback that this doesn't clearly communicate the page is top level, but seems fine and iterative. What's the motivation for placing |
In terms of tactics to approaching this issue: can we focus on bringing the missing items that exist in "details" but not in "inspector" into "inspector" first and leave the redesigns for later. The goal is to be in a state where we ready to remove the "details" panels for 6.6 and the polish/design can happen at any time (in 6.6 and further) |
Yup, good reminder :) For pages the missing pieces are; excerpt, word-count, and time-to-read. The latter two can appear alongside the 'last modified' detail, and excerpt can be displayed (uneditable) beneath the featured image (likely with truncation to four or five lines): For templates we're missing settings. These can take the same format as post meta (displayed in rows that open popovers): For patterns / template parts we're missing sync status and description. Description can appear beneath the title. Sync status can be indicated via icon color, and the inclusion of a chip similar to the one found in data views: |
@jorgefilipecosta for the navigation menus... assuming the Inspector will only be accessible in the full-screen editor for 6.6 (with access in data views coming later), I think this approach is probably the way to go for now, both for single-menu and multi-menu scenarios:
So, when editing a Header template part, the Inspector would include the following panels: (I appreciate the "Site Logo" and "Site Title" items would come later). |
The new discussion panel design is proposed at #61357. |
@ntsekouras I noticed that now that we've added the post title to the Inspector, it gets repeated on mobile: We can probably remove that mobile-only panel heading now. |
@ntsekouras will this also apply to the "Stick to the top of the blog" option for posts? |
I updated the OP to include the latest summary panel designs. Details can still change a little but this seems fairly solid now. The main missing pieces in terms of 6.6 seem to be: Pages
Posts
Templates
Patterns / Template parts
Navigation menus
All
|
I've started work for moving the home template details to inspector controls. |
What's left here? Should we close this issue now? |
I think we can close this as its main goal was to move info from details view to inspector controls. There are some small things to polish in inspector controls, but can be tracked separately like in this issue: #60291. |
Hi @jameskoster, Regarding: "Move 'Pattern categories' to a meta row rather than a panel.". It seems like the categories here are like the tags or categories of a post. In a post they are in a panel should the patterns be equal? If we move to a row the issue is that a pattern may have 4 or 5 categories and the row may become huge but I can give it a try. Regarding "Settings for templates like Blog Home" I guess it was the post per page and discussion settings which is now concluded right? |
@jorgefilipecosta I think we can hold off on that one until 6.7. There's a dedicated issue and some discussion here: #61852. |
In site editor currently the details view in navigation sidebar about the selected entity(page, template, etc..) shares a lot of information with contents/panels in the inspector sidebar.
It would be good to merge them and see how we can eventually make a reusable component that can used in other places too. An example would be to show the inspector controls somehow in the entities list that use the new Data Views(pages, patterns, etc..).
The process should be additive and not reductive. We should add whatever is missing from the details view to the inspector controls. Some duplication already exists and it's fine to add a bit more until the changes have completed.
Details view contain a lot of
readonly
information in contrast to inspector controls. If some item can be made editable(ex Featured Image), it should be added withedit
functionality.The issue is not exhaustive and design can be discussed either here or on the related PRs. It's meant to be an initial break down of tasks to parallelize work and can be updated.
Design
Tasks
title
editable, either with rich text or arename
action in ellipsis menu(will need design discussions)The text was updated successfully, but these errors were encountered: