Inspector: Remove revisions panel #61867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
the
[Feature] Site Editor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +9 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Pushed a small commit to ensure the action is hidden from post types that don't support revisions (just like the component). Also, with this, we're losing the revision count from the UI (just want to make sure that it's ok). |
youknowriad
approved these changes
May 22, 2024
|
@youknowriad Ideally the revisions menu item would include the count as a |
|
It's not trivial I think, the "label" of the action need to be a component and not sure we support that @ntsekouras @jorgefilipecosta |
|
I could get it to work by adding gutenberg/packages/editor/src/components/post-actions/index.js Lines 92 to 95 in f49e0b5 But I wasn't able to update Seems as though it'd be possible given the count is already available: I feel like I'm missing something obvious :D |
ntsekouras
force-pushed
the
update/post-revisions-link
branch
from
8597c16
to
d281b55
Compare
Yeah, we don't for now it would involve some exploring to see what a good API for that would be. Is that a blocker for this PR and the removal of the panel? --edit I'll open a separate PR to support labels as components. |
|
Not a blocker. |
|
I guess some tests will need updating here. |
ntsekouras
force-pushed
the
update/post-revisions-link
branch
from
58e4875
to
a895c42
Compare
ntsekouras
approved these changes
May 27, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
7 tasks
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #59689.
What?
Remove the revisions panel from the document inspector.
Why?
Revisions are now accessible from the ellipsis menu which offers more appropriate prominence.
Testing Instructions