Update: Implement the new discussion panel design. #61357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
7 tasks
|
Size Change: +569 B (+0.03%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
update/implement-the-new-discussion-panel-design
branch
from
2a60d9a
to
2973c73
Compare
|
Thanks for the ping. The radio controls seem to be a bit squished: 
We should probably fix that in the component (cc @WordPress/gutenberg-components - there seems to be a missing Speaking of aligning with the Status dialog, would it be possible to match the spacing between radios? The button label references pingbacks and trackbacks when editing pages, but as I understand it pages don't support them? We need to do something about this button label: 
Maybe something like:
|
This is a valid issue and it will occur with the I've worked on resolving this independently in #61476. I think |
|
@tyxla Thanks, I'll take a look at your PR. To be clear I think we should do both;
|
jorgefilipecosta
force-pushed
the
update/implement-the-new-discussion-panel-design
branch
2 times, most recently
from
f6dfb4b
to
c499802
Compare
|
Hi @jameskoster I applied the min-width to the popover and used the suggested labels. Thank you for the review and feedback let me know if there are any other updates we should do. |
|
Thanks @jorgefilipecosta, one small tweak; Since pages do not support pingbacks, the button label can just be 'Open' or 'Closed'. Currently if you set discussion to open while editing a page the button says 'Comments only' which might suggest there are other options. Otherwise this looks good :) |
jorgefilipecosta
force-pushed
the
update/implement-the-new-discussion-panel-design
branch
from
63de2aa
to
0fae69b
Compare
Hi @jameskoster, I applied the suggestion and made the labels dependent on the post type support for trackbacks and comments. Let me know if it has the green light now :) |
jorgefilipecosta
force-pushed
the
update/implement-the-new-discussion-panel-design
branch
2 times, most recently
from
b8449ce
to
fe0aaa5
Compare
jameskoster
approved these changes
May 14, 2024
There was a problem hiding this comment.
I pushed a small tweak to adjust spacing, and make the documentation link help text for the checkbox control which seems semantically appropriate.
The mis-alignment of text between radios/checkboxes is bothersome, but that's something to fix at the component level.
jorgefilipecosta
deleted the
update/implement-the-new-discussion-panel-design
branch
|
Every time I open the new panel, I noticed that Chrome logs the following error. Screenshot
|
Mamaduka
reviewed
May 22, 2024
| const postSummarySection = page.getByRole( 'checkbox', { | ||
| name: 'Stick to the top of the blog', | ||
| } ); | ||
|
|
||
| await expect( postExcerptPanel ).toBeVisible(); | ||
| await expect( postFeaturedImagePanel ).toBeVisible(); | ||
| await expect( postSummarySection ).toBeVisible(); | ||
| await expect( postDiscussionPanel ).toHaveCount( 1 ); |
There was a problem hiding this comment.
It's recommended to use explicit assertions. See - https://github.com/WordPress/gutenberg/blob/trunk/docs/contributors/code/e2e/README.md#make-explicit-assertions.
Mamaduka
reviewed
May 22, 2024
| @@ -147,5 +150,6 @@ test.describe( 'Sidebar', () => { | |||
| await expect( postExcerptPanel ).toBeHidden(); | |||
| await expect( postFeaturedImagePanel ).toBeHidden(); | |||
| await expect( postSummarySection ).toBeHidden(); | |||
| await expect( postDiscussionPanel ).toHaveCount( 0 ); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the new discussion panel design proposed at: #59689 (comment)
cc: @jameskoster
Screenshots
Testing Instructions
Tested the discussion panel options and verified they work as expected and are correctly saved.