Add: PostCardPanel component. #59870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +524 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
add/post-sidebarcard-component
branch
from
a3500ac
to
db722ca
Compare
youknowriad
reviewed
Mar 14, 2024
packages/edit-post/src/components/sidebar/post-initial-panel/index.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
Mar 14, 2024
packages/edit-post/src/components/sidebar/post-initial-panel/index.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
Mar 14, 2024
packages/edit-post/src/components/sidebar/post-initial-panel/index.js
Outdated
Show resolved
Hide resolved
ntsekouras
reviewed
Mar 14, 2024
jorgefilipecosta
force-pushed
the
add/post-sidebarcard-component
branch
4 times, most recently
from
8505f8d
to
d1a3af0
Compare
|
Hi @youknowriad, @ntsekouras your feedback was applied 👍 |
jorgefilipecosta
changed the title
youknowriad
reviewed
Mar 16, 2024
youknowriad
reviewed
Mar 16, 2024
| __( 'Last edited %s' ), | ||
| humanTimeDiff( modified ) | ||
| ); | ||
| const icon = CARD_ICONS[ type ] || templateInfo?.icon || pageIcon; |
There was a problem hiding this comment.
There's a lot of inconsistencies and conditions in the way we compute "title", "description" and "icon" between post types. Can we track this. I'd like to have a unique way to retrieve these informations regardless of the post type. (Also this logic seems duplicated in multiple places for instance the document bar)
There was a problem hiding this comment.
➕ to this. We should have a way to retrieve this for any post type. Additionally the pageIcon as default doesn't seem right, since we show this for post too and other post types. I'm wondering if we should fallback to the postType.icon.
There was a problem hiding this comment.
I added a new private selector getPostIcon, it should be able to be used in the cases where we need icons like the document bar, if we agree with this selector as a side PR I can propose one where the selector becomes widely used.
youknowriad
reviewed
Mar 16, 2024
youknowriad
reviewed
Mar 16, 2024
youknowriad
reviewed
Mar 16, 2024
| </VStack> | ||
| </div> | ||
| ) } | ||
| { children } |
There was a problem hiding this comment.
This seems to be only used in templates and only in the site editor. I think we should remove this prop and show the areas here regardless of whether we're on site editor or post editor.
There was a problem hiding this comment.
I agree but to do that we need to move the TemplateAreas component and the selectors it uses to the editor package. It is going to be a big change I added a todo and we can do it in a separate PR (that will have a size similar to this one).
youknowriad
reviewed
Mar 16, 2024
jorgefilipecosta
force-pushed
the
add/post-sidebarcard-component
branch
from
d1a3af0
to
265ce8a
Compare
Mamaduka
reviewed
Mar 18, 2024
Comment on lines
60
to
64
| : sprintf( | ||
| // translators: %s: Human-readable time difference, e.g. "2 days ago". | ||
| __( 'Last edited %s' ), | ||
| humanTimeDiff( modified ) | ||
| ); |
There was a problem hiding this comment.
This probably will close #39312. WDYT?
There was a problem hiding this comment.
Should we also show the last edited for templates too? 🤔
There was a problem hiding this comment.
I added the last edited to the templates too.
There was a problem hiding this comment.
This is how it looks now with description and last edited date:
@jameskoster do we need any polishing here?
There was a problem hiding this comment.
Thanks for the ping. I pushed a couple of changes to match the latest styles on trunk.
Mamaduka
reviewed
Mar 18, 2024
ntsekouras
reviewed
Mar 19, 2024
|
Let's avoid the typographic widow here:
We can do that editorially, or we can apply We should also update the block card to this new layout:
Can happen separately. |
jameskoster
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Seems good to merge and continue iterating.
One detail I'd appreciate design feedback on is the inclusion of the icon. In #59689 it was omitted it for two reasons:
- It's already permanently visible in the document title bar, so is a little duplicative.
- It causes alignment awkwardness – IE do we align the text below with the title, or does it span full width? Each approach has a trade-off.
jorgefilipecosta
force-pushed
the
add/post-sidebarcard-component
branch
from
872d665
to
81364bc
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #59849
Adds a PostSidebarCard component that is reused across edit-site and edit-post. Uses the component on edit post making the inspector of edit-post similar to the inspector of edit-side.
Screenshots
Testing
Verify the inspector in edit-site is exactly as before.
Verify the inspector in edit-post works as expected and now contains the additional information at the top.