Move template areas to editor package #60179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -11 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Apr 1, 2024
| // Todo: move TemplateAreas (and the selectors it depends) to the editor package, and use it here removing the children prop. | ||
| children | ||
| } | ||
| <TemplateAreas /> |
There was a problem hiding this comment.
Should we limit this to the "template" post type for now?
There was a problem hiding this comment.
Hi @youknowriad the check was added.
jorgefilipecosta
force-pushed
the
move/template-areas-to-editor
branch
from
ba965f3
to
a5a65c9
Compare
youknowriad
approved these changes
Apr 2, 2024
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #59870.
The PostCardPanel panel component only accepted children to pass template areas.
At #59870 (comment) @youknowriad suggested removing the children prop and using template areas directly on the component.
This PR does that change.
To do that change the following sub-changes were done.
Testing Instructions
Open a template and verify the template areas still appear on the template inspector without any noticeable change when compared to the trunk.