Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent block selection from less than ideal dark-theme-focus #64548

Closed
richtabor opened this issue Aug 15, 2024 · 1 comment · Fixed by #64549
Closed

Inconsistent block selection from less than ideal dark-theme-focus #64548

richtabor opened this issue Aug 15, 2024 · 1 comment · Fixed by #64549
Assignees
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

richtabor commented Aug 15, 2024

When switching to distraction free mode, the outlines turn white.

As you can see when not in distraction free mode, the outlines are fine. The inconsistencies of the dark-theme-focus color actually make it less of an ideal experience.

I say we remove these inconsistencies, and perhaps explore a more robust implementation in the future that accounts for the background color of sections/patterns—not just the whole site.

Really, the dark theme focus is necessary when the background color whatever parent block you're selected in, is not contrasting appropriately. It's not a matter of light vs. dark, but rather comparatively against the admin color. I.e. you have a blue background, you won't see the blue outline.

That's the real problem to solve for—this current dark-theme-focus implementation does not account for those, but does introduce an inconsistency that negatively affects the experience.

CleanShot.2024-08-15.at.10.31.04.mp4
@richtabor richtabor added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. labels Aug 15, 2024
@richtabor
Copy link
Member Author

Related #60300 #60299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant