Remove inconsistent dark theme focus style on block selection #64549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -233 B (-0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9e088d9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10405764506
|
|
So we're keeping the |
Yes, it's still leveraged by the spacer block and a few other places. I want to review updating those selectively as well — as you can see in the recording above the spacer block can be basically invisible as-is. |
artemiomorales
added
the
CSS Styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #64548 by removing the dark theme focus style applied on block selection. I'm leaving the class added as it's leveraged in more optimal areas, like on spacer block selection (but we likely should leverage admin color as well, as it has the same issue (when presented on a light background, but the theme is dark).
Why?
This is fine, to remove the inconsistency in a timely manner, but a next step would be to explore having the dark theme applied based on the contrast of the site background color and the current admin color, if the contrast value fails, then augment the current admin color to pass — rather than go for a full white.
And secondly, this dark theme class may need to be re-applied/checked based on the background color of blocks/parent blocks—so that you don't end up in a scenario where you have a white background with white block selection styles (not uncommon on a dark site with a white section style).
How?
Testing Instructions
Visuals
Before
CleanShot.2024-08-15.at.10.49.03.mp4
After
CleanShot.2024-08-15.at.10.51.37.mp4