Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Transformation from Separator to Spacer #65492

Open
MadtownLems opened this issue Sep 19, 2024 · 1 comment
Open

Add Transformation from Separator to Spacer #65492

MadtownLems opened this issue Sep 19, 2024 · 1 comment
Labels
[Block] Separator Affects the Separator Block [Block] Spacer Affects the Spacer Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.

Comments

@MadtownLems
Copy link

What problem does this address?

We are still dealing with lots of old content being converted into the Block Editor, and as white space was hard to control in the Classic Editor, people have made liberal use of hr's, which get turned into separator blocks in the conversion process. It has become very commonplace for us to replace them with Separator blocks and just rely on whitespace for separation between content sections, which gives a much more modern look.

What is your proposed solution?

Add a transform from the Separator block to the Spacer block
@MadtownLems MadtownLems added the [Type] Enhancement A suggestion for improvement. label Sep 19, 2024
@skorasaurus skorasaurus added [Block] Separator Affects the Separator Block [Block] Spacer Affects the Spacer Block labels Sep 19, 2024
@rudrakshi-gupta
Copy link
Contributor

Hey, I would like to work on this issue.

rudrakshi-gupta pushed a commit to rudrakshi-gupta/gutenberg that referenced this issue Oct 18, 2024
Add a transform from the Separator block to the Spacer block
ff1cdd5 
Feat WordPress#65492
talldan added a commit that referenced this issue Oct 24, 2024
@rudrakshi-gupta @talldan
Add Transformation from Separator to Spacer (#66230)
5b7ac9e 
* Add a transform from the Separator block to the Spacer block

* Add a transform from the Separator block to the Spacer block

Feat #65492

* Add transformation from spacer to separator

- Remove the default height of 50px after transformation to default 100px that of Spacer
- Update the transform of blocks so that it retains anchor attribute

* Add new transformation block titles in Test

* Add new transformation block titles in Test

* Add new transformation block titles in Test and resolve linting problem

* Add new transformation block titles in Test and resolve linting problem

* Update test suite snapshot for test [mobile] to pass successfully

---------

Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: rudrakshi-gupta <rudrakshigupta@git.wordpress.org>
@mtias mtias added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Separator Affects the Separator Block [Block] Spacer Affects the Spacer Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mtias @MadtownLems @skorasaurus @rudrakshi-gupta