Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons: wrong text color on focus #6668

Closed
afercia opened this issue May 9, 2018 · 3 comments
Closed

Buttons: wrong text color on focus #6668

afercia opened this issue May 9, 2018 · 3 comments
Assignees
Labels
[Type] Bug An existing feature does not function as intended
Milestone

Comments

@afercia
Copy link
Contributor

afercia commented May 9, 2018

Both Publish buttons have a wrong color when focused (i.e. when navigating with the keyboard and they get focus). Probably related to recent work on buttons. /Cc @jasmussen

screen shot 2018-05-09 at 23 38 44

screen shot 2018-05-09 at 23 42 50

Worth also noting there's a great variety of focus styles now, not sure if that's intentional. See the buttons below (all with forced focus via browser's dev tools):

screen shot 2018-05-09 at 23 47 36

@afercia afercia added the [Type] Bug An existing feature does not function as intended label May 9, 2018
@danielbachhuber danielbachhuber added this to the 2.9 milestone May 14, 2018
@afercia afercia changed the title Publish buttons: wrong text color on focus Buttons: wrong text color on focus May 14, 2018
@afercia
Copy link
Contributor Author

afercia commented May 14, 2018

Seems this is not limited to the Publish buttons:

screen shot 2018-05-11 at 15 37 49

@nfmohit
Copy link
Member

nfmohit commented May 14, 2018

Seems this is not limited to the Publish buttons:

@afercia Just FYI, #6714 should address those and any other buttons having the .button-primary class as well.

Screenshot:
gutenberg-6729

Thank you!

@jasmussen jasmussen self-assigned this May 15, 2018
@jasmussen
Copy link
Contributor

I've noticed this too, and I've promised to help @youknowriad with #6562, which should fix this. So I've assigned myself. However I've got a bit too much on my plate these days, so I can't promise I'll make it for 2.9, so if anyone else would like to patch this in the mean time, they should feel free to.

@youknowriad youknowriad modified the milestones: 2.9, 3.0 May 16, 2018
jasmussen pushed a commit that referenced this issue May 16, 2018
This fixes #6668, inspired by @nfmohit work in #6714 (props).
youknowriad pushed a commit that referenced this issue May 21, 2018
This fixes #6668, inspired by @nfmohit work in #6714 (props).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants