Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fitting image to whole view makes arrows disappear #78

Closed
karmatosed opened this issue Feb 15, 2017 · 1 comment · May be fixed by Verdinjoshua26/gutenberg#50
Closed

Fitting image to whole view makes arrows disappear #78

karmatosed opened this issue Feb 15, 2017 · 1 comment · May be fixed by Verdinjoshua26/gutenberg#50
Labels
[Type] Bug An existing feature does not function as intended

Comments

@karmatosed
Copy link
Member

From prototype testing:

This is a small problem, but I found that fitting the image to the whole view makes the up and down arrows disappear. It’s something that I haven’t seen mentioned in the comments so far.

https://make.wordpress.org/design/2017/02/09/initial-gutenberg-prototype-editor-testing/#comment-25109

@karmatosed karmatosed added the [Type] Bug An existing feature does not function as intended label Feb 16, 2017
@jasmussen
Copy link
Contributor

Closing this in favor of #110 as that ticket sort of serves as an umbrella ticket for the side UI.

jasmussen added a commit that referenced this issue Mar 15, 2017
These mockup updates include general refinements and polish, per Github and Slack discussions. Notably around:

- Galleries. Props @j-falk for ideas here. Trash and edit buttons when selecting individual images in a gallery, and button for advanced gallery editing, where you'd also be able to add more images to the gallery, or rearrange, in the case of a slideshow version of the gallery.
- Drag and drop. Props @iseulde for the idea of showing a blue line for the dropzone. The gray area is a ghost of where you're dragging from, so the blocks don't size around when you drag.
- A new approach to inserting content. It generally happens on a newline, and the plus then shows up to the left, where the up/down arrows would show up for a non-empty block. We'd then have a permanent "insert" button somewhere in the Admin UI to go with this, for when you need to insert content between two letters. See also #78.
- Added empty versions of Quote and Image block. Imagine the use case of _type type type, press enter for newline, type `/ima` to open inserter searched to Image, press enter, arrow down, type type type_. In that case you'd simply inserted an image placeholder block which you could later upload to, or pick an image from the media library.
nylen pushed a commit that referenced this issue Mar 16, 2017
These mockup updates include general refinements and polish, per Github and Slack discussions. Notably around:

- Galleries. Props @j-falk for ideas here. Trash and edit buttons when selecting individual images in a gallery, and button for advanced gallery editing, where you'd also be able to add more images to the gallery, or rearrange, in the case of a slideshow version of the gallery.
- Drag and drop. Props @iseulde for the idea of showing a blue line for the dropzone. The gray area is a ghost of where you're dragging from, so the blocks don't size around when you drag.
- A new approach to inserting content. It generally happens on a newline, and the plus then shows up to the left, where the up/down arrows would show up for a non-empty block. We'd then have a permanent "insert" button somewhere in the Admin UI to go with this, for when you need to insert content between two letters. See also #78.
- Added empty versions of Quote and Image block. Imagine the use case of _type type type, press enter for newline, type `/ima` to open inserter searched to Image, press enter, arrow down, type type type_. In that case you'd simply inserted an image placeholder block which you could later upload to, or pick an image from the media library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants