Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns Block (beta): columns do not transition properly from 3.1 to 3.2, until after re-save #7825

Closed
GlennMartin1 opened this issue Jul 9, 2018 · 3 comments
Labels
[Block] Columns Affects the Columns Block [Feature] Blocks Overall functionality of blocks Needs Testing Needs further testing to be confirmed.

Comments

@GlennMartin1
Copy link

Describe the bug
I'm not sure how important this is, since the Columns have be designated "Beta."
None-the-less, columns created in 3.1 are corrupted in the front end in 3.2, until after resave.

To Reproduce
Steps to reproduce the behavior:

  1. Create columns in 3.1, and add content
  2. Upgrade to 3.2
  3. See the columns (front-end) are corrupted
  4. On back-end, re-save.
  5. See the columns (front-end) are corrected

Expected behavior
It should have transitioned.
Again, not sure how super-important backward-compatibility is on a "Beta" block.

Screenshots
Back-end:
backend

Corrupted after upgrade to 3.2:
project2

Fixed after resave on 3.1:
project1

@designsimply designsimply changed the title [3.2] Columns do not transition properly from 3.1, until after re-save Columns Block (beta): columns do not transition properly from 3.1 to 3.2, until after re-save Jul 11, 2018
@designsimply designsimply added [Feature] Blocks Overall functionality of blocks Needs Testing Needs further testing to be confirmed. labels Jul 11, 2018
@designsimply
Copy link
Member

Not sure how super-important backward-compatibility is on a "Beta" block.

This is a good point! It does seem like people may be ignoring the fact that the columns block is very much still in beta, and that puts us in a tough spot since it is a very cool concept and appears to be wanted! I think the best course of action for this case is to go forward without the expectation of backward compatibility since the feature (by nature of being beta) was never technically at a stable release to be backward compatible with.

Agree? Any 2nd opinions on this one? I'd love some input from others.

@chrisvanpatten
Copy link
Contributor

@designsimply agreed although I also wonder if the underlying issue should be solved still, since similar deprecations might be necessary in the future, and might be desired by block implementers? Perhaps it should be opened as a separate issue..?

@GlennMartin1
Copy link
Author

This only affects users running Gutenberg 3.1 and earlier AND only if they're using Columns (beta).

That is, no doubt, a very small subset of people. For those that this bug may still affect, all they need to do is resave that page/post, and this issue is forever fixed.

Plus, considering that Columns block was beta, the expectations shouldn't be too high.

Closing this issue.

@iandunn iandunn added the [Block] Columns Affects the Columns Block label Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Feature] Blocks Overall functionality of blocks Needs Testing Needs further testing to be confirmed.
Projects
None yet
Development

No branches or pull requests

4 participants